-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop to master #74
Conversation
- we need to be consistent about using the 'ckan-' prefix or not, but it's more flexible not to assume it
- 'html.escape' appears to be available on Py2 as well, so we can use that
- Use Fanstatic for older CKAN, Webassets for CKAN 2.9+
- use 'dataset.read' not 'package.read', and use 'dataset_read' on older CKAN
QOL-9055 add Python 3 to CI testing and fix compatibility
- Add Python snippet to more robustly retrieve IDs from test JSON - Use CKAN 2.9 by default - Robustly detect appropriate test requirement files for each plugin
- use a single function that automatically handles suffixes and alternatives
[QOL-9055] fix parameter name for 'follow' Pylons routing
@@ -1,3 +1,4 @@ | |||
{% set dataset_read_route = 'dataset.read' if h.ckan_version() > '2.9' else 'dataset_read' %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you not using your new helper function for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. However, ckanext-datarequests doesn't currently have that helper. I can add it if you're happy to go through another pull request to develop
.
Fix compatibility with CKAN 2.9 and Python 3