Develop to master #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we need to be consistent about using the 'ckan-' prefix or not, but it's more flexible not to assume it
- 'html.escape' appears to be available on Py2 as well, so we can use that
- Use Fanstatic for older CKAN, Webassets for CKAN 2.9+
- use 'dataset.read' not 'package.read', and use 'dataset_read' on older CKAN
QOL-9055 add Python 3 to CI testing and fix compatibility
- Add Python snippet to more robustly retrieve IDs from test JSON - Use CKAN 2.9 by default - Robustly detect appropriate test requirement files for each plugin
- use a single function that automatically handles suffixes and alternatives
[QOL-9055] fix parameter name for 'follow' Pylons routing
ThrawnCA
requested review from
asifaminb,
chris-randall-qol,
devonpis,
duttonw,
kundupz and
RossWebsterWork
RossWebsterWork
approved these changes
Jul 29, 2022
duttonw
approved these changes
Jul 29, 2022
| @@ -1,3 +1,4 @@ | |||
| {% set dataset_read_route = 'dataset.read' if h.ckan_version() > '2.9' else 'dataset_read' %} | |||
There was a problem hiding this comment.
are you not using your new helper function for this?
There was a problem hiding this comment.
Good point. However, ckanext-datarequests doesn't currently have that helper. I can add it if you're happy to go through another pull request to develop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compatibility with CKAN 2.9 and Python 3