Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throws "Cannot redeclare block-scoped variable 'ngDevMode'" in angular 6 #4

Closed
RezDev94 opened this issue May 8, 2018 · 8 comments
Closed

Comments

@RezDev94
Copy link

RezDev94 commented May 8, 2018

I just updated my angular to 6 and now i have this error:

image

When in remove angular4-events from ng.modules.ts, it works fine.

@qligier
Copy link
Owner

qligier commented Jun 10, 2018

Hey,
Can you try with the new version (npm install --save angular4-events@5.0.1)? It should fix issues with Angular 6 but I still haven't had time to upgrade my own projects, so feedback would be appreciated.

@boehlerlukas
Copy link

@qligier thank's for this repo! Its a great lib! Just tested to upgrade to 5.0.1 but the error still occurs.

@boehlerlukas
Copy link

@qligier it seems like buid 5.0.0 did work for me, but 5.0.1 didn't. (sorry was on angular5)

@qligier
Copy link
Owner

qligier commented Jun 12, 2018

Yep, version 5.0.1 is only compatible with Angular 6, I should have named it v6.0.0. The README has been updated to clarify that.

@qligier
Copy link
Owner

qligier commented Jun 18, 2018

Closing this issue as it should have been fixed with v5.0.1 update.

@qligier qligier closed this as completed Jun 18, 2018
@OlehRb
Copy link

OlehRb commented Jun 22, 2018

@qligier Hi there, I am having the same issue, but using 5.0.1 doesn't help. I tried to install your library through yarn and npm, but none of the attempts finished successfully.
My angular version is 6.0.3, angular4-events version is 5.0.1.

Is there something else I can do about it or am I missing something?

@OlehRb
Copy link

OlehRb commented Jun 22, 2018

@qligier, hmm, I guess it is issue with yarn, because initially I installed some of modules through it and they worked fine, but your module even on 5.0.1 still gave the same error. Unfortunately installing your module through npm somehow removed some modules, which were previously installed using yarn. Finally, I dropped node_modules/ folder, did npm i and I don't get this error anymore.

It would be awesome if you check why installing of your module on version 5.0.1 using yarn fails.
Also, thanks for an awesome library)

@qligier
Copy link
Owner

qligier commented Jun 26, 2018

Hey, glad you were able to get it working and thank you for investigating the issue. I have never used yarn, I'll test it when I have the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants