Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of QtWebKit, replace it with QtWebEngine #9

Open
qmc2 opened this issue Apr 10, 2022 · 9 comments
Open

Get rid of QtWebKit, replace it with QtWebEngine #9

qmc2 opened this issue Apr 10, 2022 · 9 comments

Comments

@qmc2
Copy link
Owner

qmc2 commented Apr 10, 2022

This solves a number of problems (less dependencies), however, we also lose something, e.g. the nice WebInspector if there's no alternative.

This will be done later, not in the current release (that is, in 0.244+).

@Techwolf
Copy link

Techwolf commented Apr 19, 2022

Just a note for you. I ported and updated qmc2 ebuild into my local gentoo overlay due to the public overlay was now un-maintained. In doing so, I noted one qtwebkit item and ported/update it.

# QtWebKit got removed in Qt 5.6
sed -e "s:QtWebKit/QWebView:QtWebKitWidgets/QWebView:g" \
		-i src/htmleditor/htmleditor.ui

@qmc2
Copy link
Owner Author

qmc2 commented Apr 20, 2022

Thanks, that's in "master" now.

@Techwolf
Copy link

An update. emerge update world is now "blocked" on my system due to qtwebkit is no longer aviable and the one overlay ebuild is way outdated and is blocking the world update via depensity blockers.

I found a webpage detailing how to update at https://wiki.qt.io/QtWebEngine/Porting_from_QtWebKit .

@qmc2
Copy link
Owner Author

qmc2 commented May 28, 2022

Thanks, that should help! I already did a bunch of work on it but did not release it as it became to an "endless story", because I didn't realize that (for instance) "QWebFrame has been merged into QWebEnginePage" :).

@qmc2
Copy link
Owner Author

qmc2 commented May 31, 2022

There is actually a better page, that is https://doc.qt.io/qt-5/qtwebenginewidgets-qtwebkitportingguide.html

I'm currently "porting" it, but there will remain a number of things that aren't working (as expected). I will not give this code "a go" for release...

@qmc2
Copy link
Owner Author

qmc2 commented May 31, 2022

Part 1 is done: we now support QWebEngine instead of QWebKit. See 5b423e9

However, there is still much to do... at least I learned using lambda functions while doing so :).

@qmc2
Copy link
Owner Author

qmc2 commented Jun 9, 2022

Part 2: Removed two left-overs.

@estefan3112
Copy link

I installed qt5-qtwebengine via MacPorts (very long process) and got a new binary on Apple Silicon!

@estefan3112
Copy link

estefan3112 commented Nov 14, 2022

Happy to report now that with the move to QTWebEngine, compiling under Homebrew works again (and for some reason is less of a hassle than MacPorts).

However, there is one thing I had to change manually now on Apple Silicon:

qmake -makefile -o Makefile.qmake -spec macx-clang**-arm64** VERSION=0.244 QMC2_MINGW=0 SDL=2 TARGET=qmc2-sdlmame CONFIG+=warn_off CONFIG+=release 'DEFINES+=QMC2_SDLMAME QMC2_VERSION=0.244 BUILD_OS_NAME=Darwin BUILD_OS_RELEASE=21.6.0 BUILD_MACHINE=arm64 PREFIX=/usr/local DATADIR="/Library/Application:Support" SYSCONFDIR="/Library/Application:Support" QMC2_JOYSTICK=1 QMC2_PHONON=0 QMC2_MULTIMEDIA=1 QMC2_FADER_SPEED=500 QMC2_GIT_REV=v0.243-14-g112724d69 QMC2_MAC_UNIVERSAL=0 QMC2_BROWSER_EXTRAS_ENABLED QMC2_BROWSER_PLUGINS_ENABLED QMC2_BROWSER_JAVA_ENABLED QMC2_BROWSER_JAVASCRIPT_ENABLED QMC2_YOUTUBE_ENABLED QMC2_BUNDLED_MINIZIP QMC2_BUNDLED_ZLIB' qmc2.pro

By default, it is only -spec macx-clang, which fails under Apple Silicon. With this add-on, it compiles.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants