Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant eeconfig inits #12020

Closed
wants to merge 3 commits into from

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Feb 26, 2021

Description

Dependent on #8532

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna
Copy link
Member

drashna commented Feb 27, 2021

This seems to bork my splits. Not exactly sure why.

@tzarc tzarc closed this Feb 27, 2021
@tzarc tzarc deleted the branch qmk:develop February 27, 2021 20:28
@tzarc
Copy link
Member

tzarc commented Feb 27, 2021

Sorry about that, GitHub decided to delete the develop branch from upstream when we merged it, despite being told otherwise. Reopened.

@tzarc tzarc reopened this Feb 27, 2021
@zvecr
Copy link
Member Author

zvecr commented Feb 27, 2021

This seems to bork my splits. Not exactly sure why.

works on my lets_splits so i assume its down to one of the enabled features. However more testing will happen in due course.

@stale
Copy link

stale bot commented Apr 18, 2021

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale
Copy link

stale bot commented Jun 2, 2021

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.

@stale stale bot closed this Jun 2, 2021
@zvecr zvecr reopened this Jun 16, 2021
@stale stale bot removed the awaiting changes label Jun 16, 2021
@drashna
Copy link
Member

drashna commented Jun 16, 2021

For testing, been running this for a while, and doesn't seem to cause any issues.

@zvecr
Copy link
Member Author

zvecr commented Dec 15, 2023

Closing as the required change will be staged separately.

TODO:

  • haptic
  • audio
  • steno
  • split handedness

@zvecr zvecr closed this Dec 15, 2023
@zvecr zvecr deleted the feature/single_eeprom_init branch December 15, 2023 23:55
@zvecr zvecr mentioned this pull request Dec 23, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants