-
-
Notifications
You must be signed in to change notification settings - Fork 42.4k
Add HT32 support to core #14388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HT32 support to core #14388
Conversation
|
Retargeted to |
a0b1c64 to
be8d85c
Compare
|
@drashna fixed |
… patched ChibiOS-contrib (AnnePro2)
Add persistent led support with eeprom (OpenAnnePro#9) * adding HT32 support to chibios SPI master driver update spi driver, fix bad merging with master
HT32: Fix formatting: tmk_core/protocol/chibios/usb_main.c Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
a487098 to
37b6928
Compare
|
An Anne Pro 2 arrived this afternoon, will see what I can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spi_master.c changes are going to need some rework, so the platform specific logic is easier to maintain. However as this is also an issue with existing code, i see no reason to hold this PR up.
|
@tzarc friendly ping |
* tmk_core: temporary fix to allow HT32 based keyboards to work without patched ChibiOS-contrib (AnnePro2) * HT32: add spi support Add persistent led support with eeprom (qmk#9) * adding HT32 support to chibios SPI master driver update spi driver, fix bad merging with master * HT32: fix formatting HT32: Fix formatting: tmk_core/protocol/chibios/usb_main.c Co-authored-by: Drashna Jaelre <drashna@live.com> * HT32: Apply suggestions from fauxpark's code review Co-authored-by: Ryan <fauxpark@gmail.com> * HT32: update spi driver * ht32: apply code review suggestions, remove old workaround Co-authored-by: tech2077 <tech2077@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
* tmk_core: temporary fix to allow HT32 based keyboards to work without patched ChibiOS-contrib (AnnePro2) * HT32: add spi support Add persistent led support with eeprom (qmk#9) * adding HT32 support to chibios SPI master driver update spi driver, fix bad merging with master * HT32: fix formatting HT32: Fix formatting: tmk_core/protocol/chibios/usb_main.c Co-authored-by: Drashna Jaelre <drashna@live.com> * HT32: Apply suggestions from fauxpark's code review Co-authored-by: Ryan <fauxpark@gmail.com> * HT32: update spi driver * ht32: apply code review suggestions, remove old workaround Co-authored-by: tech2077 <tech2077@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Description
This adds HT32 support to QMK needed for the Anne Pro 2 keyboard (#14385)
Types of Changes
Issues Fixed or Closed by This PR
Checklist