Add via keymap to AL1 #16499
Merged
Add via keymap to AL1 #16499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keymap
via
zvecr
requested changes
Mar 2, 2022
There was a problem hiding this comment.
As a bare minimum, the keymap should really compile
quantum/dynamic_keymap.c:72:13: note: '#pragma message: (1024 - 1) - (((((35) + 3) + 1) + 0) + (4 * 7 * 20 * 2)) < 100'
72 | # pragma message STR(DYNAMIC_KEYMAP_EEPROM_MAX_ADDR - DYNAMIC_KEYMAP_MACRO_EEPROM_ADDR) " < 100"
| ^~~~~~~
quantum/dynamic_keymap.c:73:6: error: #error Dynamic keymaps are configured to use more EEPROM than is available.
73 | # error Dynamic keymaps are configured to use more EEPROM than is available.
| ^~~~~
|
|
|
make[1]: *** [builddefs/common_rules.mk:453: .build/obj_al1_via/quantum/dynamic_keymap.o] Error 1
make[1]: *** Waiting for unfinished jobs....
fauxpark
requested changes
Mar 2, 2022
|
Since I'm guessing you have this board, would you also be able to verify it still works with #16331 applied? |
fauxpark
approved these changes
Mar 3, 2022
drashna
approved these changes
Mar 14, 2022
cadusk
pushed a commit
to cadusk/qmk_firmware
that referenced
this pull request
Mar 14, 2022
* qmk/develop: (696 commits) Sentence correction (qmk#16650) [Keyboard] Add via keymap to AL1 (qmk#16499) Rename TICK to TICK_EVENT to prevent naming conflicts (qmk#16649) [Keyboard] Add BAMFK-1 (qmk#16409) Disable RGB matrix pixel animations for some boards (qmk#16643) keebio/iris: Add ifdefs to encoder callbacks (qmk#16642) bolsa/damapad - Fix missing layout macro (qmk#16639) Mousekeys fix (qmk#16640) Fix oneshot toggle logic (qmk#16630) Fix 40percentclub USB descriptors (qmk#16638) [Core] Move `has_mouse_report_changed` function to `report.c` (qmk#16543) ISP flashing guide: add instructions for flashing STM32duino bootloader (qmk#16568) Move keyboard USB IDs and strings to data driven: 0-9 (qmk#16481) USB-USB converter cleanup (qmk#16618) [Keyboard] Add "Uno" rev2 (qmk#14071) [Keyboard] Add support for Jels60 (qmk#16605) helix:edvorakjp keymap change to use split_common (qmk#16532) [Keymap] Update personal crkbd keymap (qmk#16624) [Keyboard] add missing endif in glitch keyboard (qmk#16629) [Keyboard] Add damapad (qmk#16443) ...
tacahiroy
pushed a commit
to tacahiroy/qmk_firmware
that referenced
this pull request
Mar 18, 2022
0xcharly
pushed a commit
to Bastardkb/bastardkb-qmk
that referenced
this pull request
Jul 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a via enabled keymap for the AL1.
Original QMK firmware code by TriangleLab (I think).
Types of Changes
Issues Fixed or Closed by This PR
Checklist