Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QP] Check BPP capabilities before loading the palette #16863

Merged
merged 1 commit into from
Apr 16, 2022
Merged

[QP] Check BPP capabilities before loading the palette #16863

merged 1 commit into from
Apr 16, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Apr 16, 2022

Description

Loading and drawing an image with 256 colors on a firmware with 16 colors maximum enabled, leads to memory corruption because the palette is loaded before checking if it this is even possible. This overwrites unrelated memory in https://github.com/qmk/qmk_firmware/blob/develop/quantum/painter/qp_draw_core.c#L124-L141. Without the change the firmware hard-faults at runtime.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90 KarlK90 requested a review from tzarc April 16, 2022 21:59
@github-actions github-actions bot added the core label Apr 16, 2022
@KarlK90 KarlK90 requested a review from a team April 16, 2022 21:59
@tzarc tzarc merged commit 147e57f into qmk:develop Apr 16, 2022
@KarlK90 KarlK90 deleted the fix/quantum_painter_memory_corruption_256_colors branch April 16, 2022 22:33
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Apr 18, 2022
Merge remote-tracking branch 'qmk/develop' into develop
f21cbb7 
* qmk/develop: (163 commits)
  Expose API for hardware unique ID (qmk#16869)
  [Keyboard] Add CrimsonKeyboards' Resume1800 (qmk#16842)
  [Keyboard] sandbox - fix keymaps (qmk#16873)
  [Keyboard] Add deskpad (qmk#15602)
  Fix one-shot locked modifiers (qmk#16114)
  Ploopy Trackball Mini: only define DPI options as needed (qmk#16160)
  [Keyboard] Add the Ciel (qmk#16816)
  [Keyboard] Add digicarpice (qmk#16791)
  [Keyboard] SharkPCB release Beta compatibility (qmk#16713)
  Add customizable snake and knight animation increments (qmk#16337)
  [Keyboard] Add sandbox keyboard (qmk#16021)
  Anne Pro 2 Refactor (qmk#16864)
  Refine LED indicator documentation (qmk#16304)
  Fix qmk#16859. (qmk#16865)
  [QP] Check BPP capabilities before loading the palette (qmk#16863)
  rgblight: Add functions to stop blinking one or all but one layer (qmk#16859)
  Heatmap incorrect matrix effect workaround (qmk#16315)
  [Keyboard] Add Phase One keyboard (qmk#16430)
  Fix Xorg segfault with KeebCats PCBs (qmk#16434)
  Add GET_TAPPING_TERM macro to reduce duplicate code (qmk#16681)
  ...
0xcharly pushed a commit to Bastardkb/bastardkb-qmk that referenced this pull request Jul 4, 2022
@KarlK90 @zykrah
[QP] Check BPP capabilities before loading the palette (qmk#16863)
979ed8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KarlK90 @tzarc