Erase before clearing EEPROM #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nooges
force-pushed
the
erase-before-clear
branch
from
10c5c7f
to
dcd6f20
Compare
fauxpark
approved these changes
Apr 7, 2020
|
In this case, wouldn't it be better to have "erase eeprom" as a checkbox, and have it part of the flash firmware option? This way, there is less of a possibility for users to screw up? |
|
My goal is to have the Toolbox determine whether to do a full chip erase or not by looking at the USB device revision - QMK-DFU will have 0x0936 (qmk/lufa#7) whenever we update the LUFA submodule again, and people start generating bootloaders from that. Obviously... this will miss pre-existing QMK-DFUs. Another option would be to just bruteforce it, try the EEPROM clear on its own first and check if it failed before running a full chip erase. |
drashna
approved these changes
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rollbacks the removal of the erase command done in #75 and adds a message to remind user to reflash firmware.
Types of Changes
Issues Fixed or Closed by This PR