Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onSave method called twice if both saveOnBlur and saveOnEnter attributes set to true #83

Closed
KeithGillette opened this issue Aug 1, 2017 · 2 comments

Comments

@KeithGillette
Copy link

We are using ngx-inline-editor with hideButtons set to true and want to have the input text value saved either when the user presses Enter or clicks outside the input, causing the the input to blur, so we have set both saveOnBlur and saveOnEnter to true. This causes the method bound to onSave to be called twice if the user presses Enter, perhaps because that action causes the input to blur. Since the same user action is triggering the save, I think that the onSave method should only be invoked once.

@tonivj5
Copy link
Collaborator

tonivj5 commented Aug 2, 2017

I understand your problem and you are right! onSave should only trigger once

Thanks for your reporting 👍

@tonivj5 tonivj5 closed this as completed in 2024c0a Aug 5, 2017
@tonivj5
Copy link
Collaborator

tonivj5 commented Aug 5, 2017

It is fixed in 0.2.0-alpha.9 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants