New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement s3_force_path_style #94

Closed

exadeci opened this issue Nov 24, 2014 · 4 comments

Contributor

exadeci commented Nov 24, 2014

I'm on a pretty specific S3 and there seems to be a missing option on this gem the s3_force_path_style: true (https://github.com/aws/aws-sdk-ruby/blob/91700223be98d1e12f63a24ff260c021ebb8f0cb/lib/aws/core/configuration.rb#L132-L134)

Or did I missed it ?

Owner

qoobaa commented Nov 24, 2014

It may be missing.

Contributor Author

exadeci commented Nov 24, 2014

Returning false with the vhost? method in bucket seems to make it work.
I'll make a PR if I get the time to implement a cleaner way to do it.

Collaborator

arthurnn commented Apr 12, 2015

@exadeci send the PR, and I will review it.
thanks

Contributor Author

exadeci commented Apr 14, 2015

Here it's: #98

arthurnn closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment