Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA junctions must include roles emitter and base (and intrinsic, optionally) #18

Open
Tracked by #16
dalonsoa opened this issue Oct 19, 2022 · 0 comments
Open
Tracked by #16
Labels
enhancement New feature or request Hacktoberfest

Comments

@dalonsoa
Copy link
Contributor

dalonsoa commented Oct 19, 2022

Problem

DA Junctions MUST have:

  • 1 layer with emitter role
  • 1 layer with base role
  • 1 layer with intrinsic role (optional)
  • Other layers

At the moment there is no enforcement of this, so when solcore tries to solve the problem, it fails.

Possible solution

When putting together the structure for solcore and before the junction is added to the structure here, there should be a check that the structure of the junction is indeed valid. This should be a separate function.

If that validation fails, the process should be interrupted and a pop-up window should inform the user of what is wrong with the structure.

@dalonsoa dalonsoa changed the title Name of layers in DA junctions should be enforced to be either emitter, intrinsic or base DA junctions must include roles emitter and base (and intrinsic, optionally) Oct 19, 2022
@dalonsoa dalonsoa added enhancement New feature or request Hacktoberfest labels Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Hacktoberfest
Projects
None yet
Development

No branches or pull requests

1 participant