Ensure Content-Length is Sent #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Content-Length for JSON and URL Encoded Request bodies. This ensures that Content-Length is provided in the Request header. This prevents Transfer-Encoding: chunked from being specified by https://go.dev/src/net/http/transfer.go In particular, the Microsoft Graph API Token Endpoint doesn't permit Transfer-Encoding: chunked and this is the genesis of the fix.
b5
reviewed
Jun 10, 2022
betterengineering
added a commit
to tidbyt/pixlet
that referenced
this pull request
Jul 27, 2022
This commit bumps starlib to the main branch to pull in this change: qri-io/starlib#170
betterengineering
added a commit
to tidbyt/pixlet
that referenced
this pull request
Jul 27, 2022
This commit bumps starlib to the main branch to pull in this change: qri-io/starlib#170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added specification of Content-Length during creation of the Request Body for URL Encoded and JSON Encoded content.
The existing implementation uses the ioutil.NopCloser method to create the Request body, which triggers ShouldSendChunkedRequestBody in https://go.dev/src/net/http/transfer.go that results in the Request Header specifying Transfer-Encoding: Chunked.
This change enables compatibility with Endpoints (such as Microsoft Graph APIs) that do not support Transfer-Encoding: Chunked
Testing: I've rebuilt the new http.go library into the Pixlet application: https://github.com/tidbyt/pixlet and hit multiple endpoints at Google and MSFT cloud with successful result (about 10 different API calls)