Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Redirect Handling & Add Tests #9

Open
b5 opened this issue Aug 13, 2018 · 0 comments
Open

Refactor Redirect Handling & Add Tests #9

b5 opened this issue Aug 13, 2018 · 0 comments
Labels
bug Something isn't working test Adding missing or correcting existing tests

Comments

@b5
Copy link
Member

b5 commented Aug 13, 2018

this came out of #2

Our redirect logic is currently untested. We've already identified a potential bug:

Will w.Completed() in redirect handler going to potentially cause the coordinator to stop early? (If there are no more items in the queue, this marks the URL the coordinator queued as done, even though there are more requests in the redirect chain here to be made.)

We intended to modify the logic of how redirects work to be a slice of strings that traces the entire redirect path, creating a resource for each stop along the way. We should implement this & add tests, being sure to test the case of redirect count exceeding too many redirects, and having a graceful failure state.

@b5 b5 changed the title Refactor Redirect Hangling & Add Tests Refactor Redirect Handling & Add Tests Aug 13, 2018
@b5 b5 added bug Something isn't working test Adding missing or correcting existing tests labels Aug 13, 2018
@b5 b5 added this to the Sitemap Proof-Of-Concept milestone Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Adding missing or correcting existing tests
Projects
None yet
Development

No branches or pull requests

1 participant