You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our redirect logic is currently untested. We've already identified a potential bug:
Will w.Completed() in redirect handler going to potentially cause the coordinator to stop early? (If there are no more items in the queue, this marks the URL the coordinator queued as done, even though there are more requests in the redirect chain here to be made.)
We intended to modify the logic of how redirects work to be a slice of strings that traces the entire redirect path, creating a resource for each stop along the way. We should implement this & add tests, being sure to test the case of redirect count exceeding too many redirects, and having a graceful failure state.
The text was updated successfully, but these errors were encountered:
b5
changed the title
Refactor Redirect Hangling & Add Tests
Refactor Redirect Handling & Add Tests
Aug 13, 2018
b5
added
bug
Something isn't working
test
Adding missing or correcting existing tests
labels
Aug 13, 2018
this came out of #2
Our redirect logic is currently untested. We've already identified a potential bug:
We intended to modify the logic of how redirects work to be a slice of strings that traces the entire redirect path, creating a resource for each stop along the way. We should implement this & add tests, being sure to test the case of redirect count exceeding too many redirects, and having a graceful failure state.
The text was updated successfully, but these errors were encountered: