Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depend on microlens instead of lens? #129

Closed
unhammer opened this issue Jan 13, 2020 · 3 comments
Closed

Depend on microlens instead of lens? #129

unhammer opened this issue Jan 13, 2020 · 3 comments

Comments

@unhammer
Copy link

Microlens has a quite a bit smaller dependency footprint than lens, but is often a drop-in replacement. See https://github.com/fosskers/microlens-aeson/#microlens-aeson for a visual comparison of the *-aeson versions. Would it be possible to have xlsx depend on microlens instead? It'd shorten our clean-build times quite a bit :)

@qrilka
Copy link
Owner

qrilka commented Jan 13, 2020

I think the library doesn't use advanced features of lens so should be compatible with microlens but I don't think there is enough motivation to change the default lens library. Quite a lot of applications use it already or it could come with some other dependency.
But I'm OK with having a Cabal flag with which lens could be replaced with microlens if that won't change API significantly

@qrilka
Copy link
Owner

qrilka commented Nov 27, 2020

@unhammer I think this was resolved in 0.8.2 by #133

@qrilka qrilka closed this as completed Nov 27, 2020
@unhammer
Copy link
Author

Awesome =D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants