Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font attribute <strike/> is not being parsed correctly. #52

Closed
vesten opened this issue Jun 29, 2016 · 3 comments
Closed

Font attribute <strike/> is not being parsed correctly. #52

vesten opened this issue Jun 29, 2016 · 3 comments
Labels
bug

Comments

@vesten
Copy link

vesten commented Jun 29, 2016 •
edited
Loading

In the attached .xlsx file, the cell C2 has the font attribute <strike/> however it parses (_fontStrikeThrough) as a 'Nothing' value. foo.xlsx
@qrilka
Copy link
Owner

qrilka commented Jun 29, 2016

Yeah, it appears we don't treat elements with defaults properly.
Fixing only strike is easy but I guess I will need to check other such cases also (e.g. <u/> should be treated as Just FontUnderlineSingle).
Thanks for reporting it.

@qrilka qrilka added the bug label Jun 29, 2016
@qrilka
Copy link
Owner

qrilka commented Jul 1, 2016

Fixed by 9f87050

@qrilka qrilka closed this as completed Jul 1, 2016
@vesten
Copy link
Author

vesten commented Jul 2, 2016

The fix works well. Thanks @qrilka for the time attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qrilka @vesten