New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor logic errors on qt3scan #158

Closed

vasilisniaouris opened this issue Mar 23, 2024 · 0 comments · Fixed by #159

Assignees

Labels

code improvement GUI work invalid

Collaborator

vasilisniaouris commented Mar 23, 2024 •

edited

Loading

The full range of x and y is not scanned. For both axes the last point is neglected.
The scan-stop logic is wrong. The stop method of the controller is called twice, once to stop the scan and one to perform post-stop actions. These functionalities need to be separated in two different actions.

vasilisniaouris added invalid GUI work labels

vasilisniaouris self-assigned this

vasilisniaouris changed the title ~~Minor bugs on qt3scan~~ Minor logic errors on qt3scan

vasilisniaouris added the code improvement label

vasilisniaouris linked a pull request

that will close this issue

Hyperspectral bug fixes #159

Merged

cmordi closed this as completed in #159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment