Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1070 Bare Brace map constructor syntax #1071

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

michaelhkay
Copy link
Contributor

Makes the keyword "map" in map constructors optional.

Fix #1070

@michaelhkay michaelhkay added the Tests Needed Tests need to be written or merged label Mar 12, 2024
Copy link
Contributor

@ChristianGruen ChristianGruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@michaelhkay michaelhkay added Tests Added Tests have been added to the test suites and removed Tests Needed Tests need to be written or merged labels Mar 12, 2024
@michaelhkay michaelhkay added XPath An issue related to XPath XQuery An issue related to XQuery Enhancement A change or improvement to an existing feature labels Mar 17, 2024
@ndw
Copy link
Contributor

ndw commented Mar 26, 2024

The CG agreed to merge this PR at meeting 071

@ndw ndw added the Blocked PR is blocked (has merge conflicts, doesn't format, etc.) label Mar 26, 2024
@ChristianGruen
Copy link
Contributor

Sorry for creating the conflicts; I hope it’s easy to fix.

Formatting of maps and arrays:

map { 1: "I", 2: map { "II": [ "III", "IV" ] } },
{ 1: "I", 2: { "II": [ "III", "IV" ] } }

For arrays, whitespace is used after [ and before ] to illustrate that the constructs are no predicates.

@michaelhkay
Copy link
Contributor Author

I hve (a) resolved the conflicts, and (b) used the new syntax extensively in examples in the F+O and XSLT specs.

@michaelhkay michaelhkay merged commit 97a2f1d into qt4cg:master Mar 26, 2024
2 checks passed
@michaelhkay michaelhkay added Completed PR has been applied, tests written and tagged, no further action needed and removed Blocked PR is blocked (has merge conflicts, doesn't format, etc.) labels Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed PR has been applied, tests written and tagged, no further action needed Enhancement A change or improvement to an existing feature Tests Added Tests have been added to the test suites XPath An issue related to XPath XQuery An issue related to XQuery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concise syntax for map construction
3 participants