Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1207 Allow numeric predicates when filtering arrays #1217

Merged
merged 1 commit into from
May 21, 2024

Conversation

michaelhkay
Copy link
Contributor

Fix #1207

Also a minor change: $V[23, "fred"] now throws FORG0006 rather than XPTY0004. This keeps it compatible with 3.1 (in case anyone is catching the errors), and is more uniform: it seems unreasonable for $V[23, "fred"] and $V["fred", 23] to throw different errors.

@michaelhkay michaelhkay added XPath An issue related to XPath XQuery An issue related to XQuery Enhancement A change or improvement to an existing feature Tests Needed Tests need to be written or merged labels May 14, 2024
@michaelhkay michaelhkay force-pushed the 1207-positional_predicates_for_arrays branch from f69c3d8 to fa2921b Compare May 20, 2024 22:06
@michaelhkay
Copy link
Contributor Author

Rebased against current master to get a better diff.

@ndw
Copy link
Contributor

ndw commented May 21, 2024

The CG agreed to merge this PR at meeting 078.

@ndw ndw merged commit 5d9e4b9 into qt4cg:master May 21, 2024
2 checks passed
@michaelhkay michaelhkay added Completed PR has been applied, tests written and tagged, no further action needed and removed Tests Needed Tests need to be written or merged labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed PR has been applied, tests written and tagged, no further action needed Enhancement A change or improvement to an existing feature XPath An issue related to XPath XQuery An issue related to XQuery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Array filter: Positional access
3 participants