Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 151: map:build #203

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Issue 151: map:build #203

merged 3 commits into from
Oct 18, 2022

Conversation

michaelhkay
Copy link
Contributor

Drops the proposed map:group-by function, replacing it with the more powerful map:build.

@michaelhkay
Copy link
Contributor Author

For consistency, the default for the fourth parameter should be written fn:op(',') rather than op(','). The "fn" prefix should also be used with "concat" and "op" in the Notes section.

The formatting of the "more formally" equivalent expression has gone awry.

@michaelhkay
Copy link
Contributor Author

I note that the old map:group-by() proposal said that if the key function returns an empty sequence, no entry is created in the index; the new spec makes this a type error. This seems a useful capability and I propose we reinstate it.

@ndw
Copy link
Contributor

ndw commented Oct 18, 2022

Accepted at meeting 007.

@ndw ndw merged commit 00a20f6 into qt4cg:master Oct 18, 2022
@michaelhkay michaelhkay deleted the map-build-test branch October 18, 2022 19:27
@ndw ndw mentioned this pull request Nov 11, 2022
@michaelhkay michaelhkay added Tests Added Tests have been added to the test suites Completed PR has been applied, tests written and tagged, no further action needed labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed PR has been applied, tests written and tagged, no further action needed Tests Added Tests have been added to the test suites
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants