Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fn:parse-html to apply review feedback. #330

Merged
merged 7 commits into from
Feb 8, 2023

Conversation

rhdunn
Copy link
Contributor

@rhdunn rhdunn commented Jan 31, 2023

This PR applies the following review comments:

  • QT4CG-016-03: RD to add a note clarifying “known character encoding”
  • QT4CG-016-04: RD to add a note clarifying the “”/”” html/version combination
  • QT4CG-016-05: RD to add a “todo” noting the dependency on keyword arguments
  • QT4CG-016-06: RD to reword the introduction to mapping to clarify who’s doing the mapping
  • QT4CG-016-08: RD to clarify how namespace comparisons are performed.
  • QT4CG-016-09: RD to add a note stating that the local name should always be lowercase
  • QT4CG-016-10: RD to consider how to clarify parsed entity parsing.

@rhdunn rhdunn merged commit 2a9dd96 into qt4cg:master Feb 8, 2023
@rhdunn rhdunn deleted the parse-html-updates branch February 28, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant