Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

452: window: make 'start' and 'when' optional #483

Merged
merged 3 commits into from
May 18, 2023
Merged

Conversation

ChristianGruen
Copy link
Contributor

No description provided.

@michaelhkay
Copy link
Contributor

A minor quibble: in the sentence "The end clause can only be omitted in [4.14.4.1 Tumbling Windows]"

(a) "can only be omitted" should be "can be omitted only"

(b) we shouldn't be using a specref like this: it's a reference to the concept not to the section in which it is described. Perhaps we should use an <nt> ref here, "can be omitted only within a TumblingWindowClause.

@michaelhkay
Copy link
Contributor

Could you add an entry to Appendix K please?

@ChristianGruen
Copy link
Contributor Author

…done

@ndw
Copy link
Contributor

ndw commented May 16, 2023

Can you resolve this merge conflict, please?

Accepted at meeting 034, 16 May 2023

@ChristianGruen
Copy link
Contributor Author

…done

@ndw ndw merged commit f082193 into qt4cg:master May 18, 2023
4 checks passed
@ChristianGruen ChristianGruen deleted the 452 branch May 20, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants