959-partial Add fn:seconds function #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianGruen
changed the title
ChristianGruen
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Thanks. I removed Fix from the initial comment, as I think we should add an alternative solution for xs:dateTime('1970-01-01T00:00:00Z'). It’s particularly tricky because of the timestamp syntax, and people may be tempted to write things like…
xs:dateTime('1970-01-01T00:00:00') + seconds( (: input from 'date +%s' or similar :) )…which gives a similar, but wrong result. fn:unix-time() would be my favorite (it seems more common to me than 'epoch', but I may be biased).
michaelhkay
added
Tests Added
|
The CG agreed to merge this issue at meeting 064 |
michaelhkay
added
XQFO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #959