Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No icon for some apps in Tasklist widget #3637

Closed
1 task done
ervinpopescu opened this issue Jun 18, 2022 · 1 comment · Fixed by #3799
Closed
1 task done

No icon for some apps in Tasklist widget #3637

ervinpopescu opened this issue Jun 18, 2022 · 1 comment · Fixed by #3799

Comments

@ervinpopescu
Copy link
Contributor

ervinpopescu commented Jun 18, 2022

The issue:

$ qtile --version
    0.21.1.dev67+g2b2cd60b

As far as I've checked, this only happens with apps that don't "publish" an X property for icon (_NET_WM_ICON, WM_ICON_NAME). Can the WM_CLASS property be used for this, possibly?

I know what I have to do, but I don't know if I have the strength to do it.

image
That little smudge of color is supposed to be the icon :)

image
Normal behaviour

$ xprop
XdndProxy(WINDOW): window id # 0x4600004
WM_CLASS(STRING) = "spotify", "Spotify"
WM_NAME(STRING) = "Spotify"
_NET_WM_NAME(UTF8_STRING) = "Spotify"
_NET_WM_STATE(ATOM) = _NET_WM_STATE_FOCUSED
_NET_FRAME_EXTENTS(CARDINAL) = 0, 0, 0, 0
_NET_WM_DESKTOP(CARDINAL) = 5
WM_STATE(WM_STATE):
		window state: Normal
		icon window: 0x0
WM_NORMAL_HINTS(WM_SIZE_HINTS):
		program specified location: 0, 0
_NET_WM_PID(CARDINAL) = 34927
WM_CLIENT_MACHINE(STRING) = "arch"
WM_PROTOCOLS(ATOM): protocols  WM_DELETE_WINDOW, _NET_WM_PING
widget.TaskList(
    parse_text=no_text,
    highlight_method="block",
    icon_size=48,
    border=colors[0],
    rounded=True,
    padding=0,
    padding_y=-3,
    margin_x=2,
    margin_y=45,
    txt_floating="🗗 ",
    txt_maximized="🗖 ",
    txt_minimized="🗕 "
),

Required:

  • I have searched past issues to see if this bug has already been reported.
@elParaguayo
Copy link
Member

What we should be doing is looking up icons installed in the user's system (using a library like xdg). This would also allow us to have icons on Wayland.

I can take a look at adding this.

@elParaguayo elParaguayo self-assigned this Jun 19, 2022
elParaguayo added a commit to elParaguayo/qtile that referenced this issue Aug 27, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes qtile#3637
elParaguayo added a commit to elParaguayo/qtile that referenced this issue Aug 28, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes qtile#3637
elParaguayo added a commit to elParaguayo/qtile that referenced this issue Aug 28, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes qtile#3637
elParaguayo added a commit to elParaguayo/qtile that referenced this issue Sep 2, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes qtile#3637
elParaguayo added a commit to elParaguayo/qtile that referenced this issue Sep 2, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes qtile#3637
elParaguayo added a commit to elParaguayo/qtile that referenced this issue Sep 14, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes qtile#3637
elParaguayo added a commit to elParaguayo/qtile that referenced this issue Sep 17, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes qtile#3637
elParaguayo added a commit to elParaguayo/qtile that referenced this issue Sep 17, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes qtile#3637
elParaguayo added a commit that referenced this issue Sep 17, 2022
Adds local icon support to TaskList widget. These enables users
to select themes for icons as well as providing icon support
for Wayland backend.

Fixes #3637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants