Fix global_defaults for Battery widget #3229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elParaguayo
force-pushed
the
issue-3228
branch
from
fc24f51
to
e59ed7b
Compare
Similar to qtile#3203, the Battery widget reads a property in __init__ which prevents it being set by global defaults. This PR fixes the issue by moving the property read to `_configure`. Fixes qtile#3228
elParaguayo
force-pushed
the
issue-3228
branch
from
e59ed7b
to
7eb71e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #3203, the Battery widget reads a property in
__init__which prevents it being set by global defaults.This PR fixes the issue by moving the property read to
_configure.Fixes #3228