Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4123 by changing keyboard layout regex on X11 backend #4228

Merged

Conversation

Malex
Copy link
Contributor

@Malex Malex commented Apr 8, 2023

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Qtile!
If you have not heard from us in a while, please feel free to ping one of the devs or anyone who has commented on the PR, as sometimes things fall through the cracks.
You can also join the chat room for real-time discussion, see the community links.
For details on what PRs might need to include before we will merge them please see the docs.

@Malex Malex mentioned this pull request Apr 8, 2023
1 task
@elParaguayo
Copy link
Member

Sorry for the delay.

Thanks for submitting this. Regex change looks good.

Were the other changes caused by black formatting?

@Malex
Copy link
Contributor Author

Malex commented Apr 25, 2023

looking around my editor settings, it seems it defaulted to yapf for this project instead. I'll take a look on how to fix the formatting defaults on my editor and switch to black for this project only

@Malex Malex force-pushed the bugfix/keyboard-layout-regex-fix-#4123 branch from 127458f to 22e880d Compare April 25, 2023 20:18
@Malex
Copy link
Contributor Author

Malex commented Apr 25, 2023

@elParaguayo fixed

@elParaguayo elParaguayo enabled auto-merge (rebase) April 26, 2023 11:35
@elParaguayo elParaguayo merged commit b3dba20 into qtile:master Apr 26, 2023
M7S added a commit to M7S/qtile that referenced this pull request Mar 24, 2024
tych0 pushed a commit that referenced this pull request Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants