Skip to content

Commit

Permalink
Deprecate ACF-qTranslate text/textarea/wysiwyg fields
Browse files Browse the repository at this point in the history
Follow-up of #1186 and #1300.
Since the standard ACF fields are better supported, those should be
preferred over the qTranslate extended fields.

In particular: text, textarea, wysiwyg are covered by the ACF standard
fields, while others only exist as qTranslate extended fields.

Deprecate softly these "duplicated" extended fields in their labels.
  • Loading branch information
herrvigg committed Mar 30, 2023
1 parent 6e80c4b commit fa95f7e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions src/modules/acf/admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -282,13 +282,13 @@ public function admin_init() {
'section-acf-extended',
__( 'Extended qTranslate fields', 'qtranslate' ),
function () {
_e( 'Additional types with a specific handling and rendering for qTranslate. Prefer the standard ACF fields as much as possible.', 'qtranslate' );
_e( 'Additional types specific to qTranslate. Prefer the standard ACF fields.', 'qtranslate' );
},
'settings-qtranslate-acf'
);
add_settings_field(
'select_qtranslate_fields',
__( 'Active types', 'qtranslate' ),
__( 'Types enabled for selection', 'qtranslate' ),
array( $this, 'render_setting_qtranslate_fields' ),
'settings-qtranslate-acf',
'section-acf-extended'
Expand Down
2 changes: 1 addition & 1 deletion src/modules/acf/fields/text.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function initialize() {
parent::initialize();
$this->name = 'qtranslate_text';
$this->category = QTX_Module_Acf_Register::ACF_CATEGORY_QTX;
$this->label .= ' [' . $this->category . ']';
$this->label .= ' [' . $this->category . ']' . ' - ' . __( 'Deprecated', 'qtranslate' );
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/modules/acf/fields/textarea.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function initialize() {
parent::initialize();
$this->name = 'qtranslate_textarea';
$this->category = QTX_Module_Acf_Register::ACF_CATEGORY_QTX;
$this->label .= ' [' . $this->category . ']';
$this->label .= ' [' . $this->category . ']' . ' - ' . __( 'Deprecated', 'qtranslate' );
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/modules/acf/fields/wysiwyg.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ function initialize() {
parent::initialize();
$this->name = 'qtranslate_wysiwyg';
$this->category = QTX_Module_Acf_Register::ACF_CATEGORY_QTX;
$this->label .= ' [' . $this->category . ']';
$this->label .= ' [' . $this->category . ']' . ' - ' . __( 'Deprecated', 'qtranslate' );
}

/**
Expand Down

0 comments on commit fa95f7e

Please sign in to comment.