Add new ACF settings to select extended qTranslate types
#1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually the extended types may be removed completely. This new feature allows to choose which extended types can be picked. The default value becomes false for all extended types. This only impacts the list of types available in the group edit. The extended types are still loaded and translated as usual. It is up to the admin to clean up pending types.
herrvigg
added a commit
that referenced
this pull request
Mar 30, 2023
Follow-up of #1186 and #1300. Since the standard ACF fields are better supported, those should be preferred over the qTranslate extended fields. In particular: text, textarea, wysiwyg are covered by the ACF standard fields, while others only exist as qTranslate extended fields. Deprecate softly these "duplicated" extended fields in their labels.
herrvigg
added a commit
that referenced
this pull request
Mar 30, 2023
Follow-up of #1186 and #1300. Since the standard ACF fields are better supported, those should be preferred over the qTranslate extended fields. In particular: text, textarea, wysiwyg are covered by the ACF standard fields, while others only exist as qTranslate extended fields. Deprecate softly these "duplicated" extended fields in their labels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eventually the extended types may be removed completely.
This new feature allows to choose which extended types can be picked.
The default value becomes false for all extended types.
This only impacts the list of types available in the group edit.
The extended types are still loaded and translated as usual. It is up to the admin to clean up pending types.