Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting devicePixelRatio #515

Merged
merged 1 commit into from
May 20, 2017
Merged

Allow setting devicePixelRatio #515

merged 1 commit into from
May 20, 2017

Conversation

DeviaVir
Copy link

As requested, reviving vitallium/qtwebkit#5 on this repo.

Original PR text:

Attempting to revive ariya/phantomjs#12839 upstream, this should allow webpage.ccp next to make use of this and actually set and overwrite the pixelratio.

Refer to ariya/phantomjs#10964 for the what and why.

@DeviaVir
Copy link
Author

ping @annulen, could you please review these changes? They've been in flight at least a year now.

@annulen
Copy link
Member

annulen commented Apr 26, 2017

I'm not sure this is a correct way to do things. If page has a view, it will also call setDevicePixelRatio from QWebPagePrivate::_q_updateScreen, resulting in inconsistent behavior. Also, there is unfixed crash #461, I think it would be better to fix it first before exposing on more way to trigger it.

@annulen annulen merged commit efc64d4 into qtwebkit:qtwebkit-stable May 20, 2017
@DeviaVir DeviaVir deleted the dpr branch May 23, 2017 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants