Allow setting devicePixelRatio #5
Conversation
| @@ -305,6 +305,8 @@ class QWEBKITWIDGETS_EXPORT QWebPage : public QObject { | |||
| virtual void triggerAction(WebAction action, bool checked = false); | |||
|
|
|||
| QSize viewportSize() const; | |||
| void setDevicePixelRatio(float ratio); | |||
| float devicePixelRatio() const; | |||
There was a problem hiding this comment.
We can't use float here, please keep it consistent with qreal.
There was a problem hiding this comment.
|
It looks like such function existed in upstream (though in WebKit2 API), but was removed, and HiDPI issue was fixed in a different way: |
|
Would love to see this go through, especially since it seems such an easy fix. :) |
|
👍 |
|
@ariya I have updated this branch so it's mergeable again. |
|
@vitallium could this be merged please? |
|
@EiNSTeiN- unfortunately, no. We're switching to a fresh QtWebKit version (https://github.com/annulen/webkit). And we decided to not merge anything in this repo, because it will be deleted soon. Sorry for that! But new QtWebKit has awesome features and improvements. We hope you will like it. But, I suggest @DeviaVir to open the same PR against the new QtWebKit. I think we will merge it. |
|
@ariya what is the plan for ariya/phantomjs#13942 regarding what @vitallium just said? I'm really hoping ariya/phantomjs#13942 would be merged to get useable pixel ratio config in phantomjs, but it looks like it won't happen here. |
Attempting to revive ariya/phantomjs#12839 upstream, this should allow webpage.ccp next to make use of this and actually set and overwrite the pixelratio.
Refer to ariya/phantomjs#10964 for the what and why.