Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Close Editor with ESP bypasses saveCheck dialogue #907

Closed
davidkircos opened this issue Dec 1, 2023 · 1 comment · Fixed by #967
Closed

bug: Close Editor with ESP bypasses saveCheck dialogue #907

davidkircos opened this issue Dec 1, 2023 · 1 comment · Fixed by #967
Labels
high priority within weeks type: bug something is broken

Comments

@davidkircos
Copy link
Collaborator

davidkircos commented Dec 1, 2023

Behavior A:

  • Make some changes in a cell's code
  • Press ESC
  • Code editor closes immediately without asking to save

Expected

  • When pressing ESC it will still ask to save first

Edit, similar behavior
Behavior B:

  • Make some changes in a cell's code
  • Click to open another editor cell
  • Original code editor closes without asking to save or automatically saving

Expected

  • Original code editor would either automatically save or give a prompt to save
@davidkircos davidkircos added type: bug something is broken high priority within weeks labels Dec 1, 2023
@luke-quadratic
Copy link
Contributor

As part of this issue, same experience when in an editor and opening a different editor/Python code cell. Have lost coding progress at least a dozen times doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority within weeks type: bug something is broken
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants