Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel Button doesn't work in error case #21

Closed
Quaese opened this issue Sep 13, 2019 · 1 comment
Closed

Cancel Button doesn't work in error case #21

Quaese opened this issue Sep 13, 2019 · 1 comment
Labels
bug Something isn't working done / fixed Issue done / bug fixed frontend

Comments

@Quaese
Copy link
Owner

Quaese commented Sep 13, 2019

Cancel button doesn't work in error case.

How to reproduce

  • go to results table
  • add new result
  • enter incorrect values (e.g. 00000 for time)
  • press cancel
    => nothing happens!
@Quaese Quaese added bug Something isn't working frontend in progress This issue is currently being worked on labels Sep 13, 2019
Quaese added a commit that referenced this issue Sep 14, 2019
@Quaese
#21 - Cancel Button doesn't work in error case
0b7cd67 
* reset error flag
* check if highscore name exists for results, otherwise show default name/text
Quaese added a commit that referenced this issue Sep 14, 2019
@Quaese
Merge pull request #23 from Quaese/fix/#21-Cancel-button-doesnt-work-…
09f7307 
…in-error-case

#21 - Cancel Button doesn't work in error case
@Quaese Quaese added done / fixed Issue done / bug fixed and removed in progress This issue is currently being worked on labels Sep 14, 2019
@Quaese
Copy link
Owner Author

Quaese commented Sep 14, 2019

Fixed with PR #23

@Quaese Quaese closed this as completed Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working done / fixed Issue done / bug fixed frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Quaese