Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle multilingual canonical and manual redirects. #142

Closed
wants to merge 30 commits into from
Closed

Handle multilingual canonical and manual redirects. #142

wants to merge 30 commits into from

Conversation

kepol
Copy link
Contributor

@kepol kepol commented Feb 23, 2023

WIP

@kepol
[ISSUE-99] (WIP) Add redirect logic to handle language path prefixes.
45b63d5
@kepol
[ISSUE-99] (WIP) Reworking redirect logic to handle language path pre…
09f9558 
…fixes.
@kepol
Merge branch '8.x-1.x' into feature/issue-99-redirect-language
0df4dec
@kepol
Merge branch '8.x-1.x' into feature/issue-99-redirect-language
f09eae7 
Manually fixed merge conflicts in :
	src/Seed.php
@kepol
[ISSUE-99] (WIP) Refactoring canonical redirects for multilingual.
3c7f4bc
@kepol
[ISSUE-99] (WIP) More refactoring for multilingual redirects.
6b56f50
@kepol
[ISSUE-99] (WIP) More logic for multilingual redirects and cleanup.
dcafa82
@kepol
[ISSUE-99] (WIP) Clean up multilingual redirect logic and logging.
8c1d2d8
@kepol
[ISSUE-99] Handle redirects when default language has no path prefix.
97ba301
@kepol
[ISSUE-99] Handle taxonomy canonical redirects in CollectionSubscriber.
9cdf7b0
@kepol
[ISSUE-99] Switch logic to not unpublish canonical redirects.
a4e954b
@kepol
[ISSUE-99] Remove unused code and clean up comments for clarity.
b00a132
@kepol kepol linked an issue Feb 23, 2023 that may be closed by this pull request
Redirects do not preserve language #99
Closed
@kepol kepol changed the title Handle multilingual canonical and manual redirects. WIP Handle multilingual canonical and manual redirects. Feb 23, 2023
@kepol kepol self-assigned this Feb 23, 2023
@kepol kepol added bug Something isn't working Drupal 8 / 9 / 10 needs work labels Feb 23, 2023
@kepol kepol marked this pull request as draft February 23, 2023 23:38
@kepol kepol changed the title WIP Handle multilingual canonical and manual redirects. DRAFT Handle multilingual canonical and manual redirects. Feb 24, 2023
@kepol
Copy link
Contributor Author

kepol commented Mar 2, 2023

Given the complexity of these fixes, I'm going to split the PRs for these issues so I'm closing this one.

@kepol kepol closed this Mar 2, 2023
@kepol kepol removed a link to an issue Mar 8, 2023
Redirects do not preserve language #99
Closed
@kepol kepol removed the needs work label Mar 8, 2023
@kepol kepol removed their assignment Mar 8, 2023
@kepol kepol changed the title DRAFT Handle multilingual canonical and manual redirects. Handle multilingual canonical and manual redirects. Jan 19, 2024
@kepol kepol added the invalid This doesn't seem right label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working Drupal 8 / 9 / 10 invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kepol