-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warning and info for queue factory. #194
Conversation
Note that I found this major bug when testing this so maybe we should fix that prior to showing this warning message: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor discussion point on this one @kepol.
modules/quant_purger/README.md
Outdated
the next core cron run. You can run the cron manually or wait for the site's | ||
cron to run on its regular schedule. For the latter, note that the static | ||
content will be out-of-sync with the Drupal site until the cron runs, which may | ||
cause confusion in some cases. Thus, it is recommended that cron is run right |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that the recommendation is to have the quant queue run drush command running separately to core cron and having its frequency increased rather than running cron after a node save.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha... could you revise how you'd like it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, I can revise
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steveworley I changed it to:
To ensure that queued content is processed in a timely manner, you can set up a
Quant cron process that is separate from the core cron which just processes the
Quant queue. This Quant cron can be run more regularly than the core cron.
If you want any tweaks, feel free to suggest specific changes.
See latest code changes that address this.
I'm going to merge this because I think the text is okay. |
Followup from #149
Adding setting to purger README and add warning across all admin pages if this isn't set since it will affect performance.
Drupal.org issue: https://www.drupal.org/project/quantcdn/issues/3398935