Added warning and info for queue factory. #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I found this major bug when testing this so maybe we should fix that prior to showing this warning message: |
steveworley
previously requested changes
Nov 6, 2023
modules/quant_purger/README.md
Outdated
| the next core cron run. You can run the cron manually or wait for the site's | ||
| cron to run on its regular schedule. For the latter, note that the static | ||
| content will be out-of-sync with the Drupal site until the cron runs, which may | ||
| cause confusion in some cases. Thus, it is recommended that cron is run right |
There was a problem hiding this comment.
I would say that the recommendation is to have the quant queue run drush command running separately to core cron and having its frequency increased rather than running cron after a node save.
There was a problem hiding this comment.
Gotcha... could you revise how you'd like it?
There was a problem hiding this comment.
actually, I can revise
There was a problem hiding this comment.
@steveworley I changed it to:
To ensure that queued content is processed in a timely manner, you can set up a
Quant cron process that is separate from the core cron which just processes the
Quant queue. This Quant cron can be run more regularly than the core cron.
If you want any tweaks, feel free to suggest specific changes.
kepol
dismissed
steveworley’s stale review
See latest code changes that address this.
|
I'm going to merge this because I think the text is okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #149
Adding setting to purger README and add warning across all admin pages if this isn't set since it will affect performance.
Drupal.org issue: https://www.drupal.org/project/quantcdn/issues/3398935