-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill tokenized texts #1034
Kill tokenized texts #1034
Conversation
Nice. RIP tokenizedTexts. Can you run revdep_check on this? Ignore the issues I’ve already fixed in #1024. |
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
=========================================
+ Coverage 89.16% 89.97% +0.8%
=========================================
Files 90 88 -2
Lines 6961 6631 -330
=========================================
- Hits 6207 5966 -241
+ Misses 754 665 -89 |
|
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
=========================================
+ Coverage 89.16% 89.97% +0.8%
=========================================
Files 90 88 -2
Lines 6961 6631 -330
=========================================
- Hits 6207 5966 -241
+ Misses 754 665 -89 |
On the revdep checks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work.
I'm going to approve and let you have the honour of merging!
No description provided.