Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kill tokenized texts #1034

Merged
merged 21 commits into from
Oct 31, 2017
Merged

Kill tokenized texts #1034

merged 21 commits into from
Oct 31, 2017

Conversation

koheiw
Copy link
Collaborator

@koheiw koheiw commented Oct 30, 2017

No description provided.

@kbenoit
Copy link
Collaborator

kbenoit commented Oct 30, 2017

Nice. RIP tokenizedTexts.

Can you run revdep_check on this? Ignore the issues I’ve already fixed in #1024.

@codecov
Copy link

codecov bot commented Oct 30, 2017

Codecov Report

Merging #1034 into master will increase coverage by 0.8%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1034     +/-   ##
=========================================
+ Coverage   89.16%   89.97%   +0.8%     
=========================================
  Files          90       88      -2     
  Lines        6961     6631    -330     
=========================================
- Hits         6207     5966    -241     
+ Misses        754      665     -89

@koheiw
Copy link
Collaborator Author

koheiw commented Oct 31, 2017

Checking 10 packages: clustRcompaR, corpustools, gofastr, phrasemachine, preText, readtext, stm, textstem, tidytext, word.alignment
Package library: /tmp/RtmpoURqdx/revdep3840f6364d5, /tmp/RtmpoURqdx/R-lib, /usr/local/lib/R/site-library, /usr/lib/R/site-library, /usr/lib/R/library
Checked clustRcompaR  : 0 errors | 0 warnings | 0 notes
Checked corpustools   : 0 errors | 0 warnings | 0 notes
Checked gofastr       : 0 errors | 0 warnings | 0 notes
Checked phrasemachine : 0 errors | 0 warnings | 0 notes
Checked preText       : 0 errors | 0 warnings | 1 note 
Checked readtext      : 0 errors | 0 warnings | 0 notes
Checked stm           : 0 errors | 1 warning  | 0 notes
Checked textstem      : 1 error  | 0 warnings | 1 note 
Checked tidytext      : 1 error  | 0 warnings | 0 notes
Checked word.alignment: 0 errors | 0 warnings | 1 note 
Checked 10/10. Elapsed 00:11. Remaining ~00:00

@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #1034 into master will increase coverage by 0.8%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #1034     +/-   ##
=========================================
+ Coverage   89.16%   89.97%   +0.8%     
=========================================
  Files          90       88      -2     
  Lines        6961     6631    -330     
=========================================
- Hits         6207     5966    -241     
+ Misses        754      665     -89

@kbenoit
Copy link
Collaborator

kbenoit commented Oct 31, 2017

On the revdep checks:

Copy link
Collaborator

@kbenoit kbenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.

I'm going to approve and let you have the honour of merging!

@koheiw koheiw merged commit 61b7d77 into master Oct 31, 2017
@koheiw koheiw deleted the kill-tokenizedTexts branch October 31, 2017 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants