Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility w/quanteda v1.0 #87

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Ensure compatibility w/quanteda v1.0 #87

merged 2 commits into from
Nov 17, 2017

Conversation

kbenoit
Copy link
Contributor

@kbenoit kbenoit commented Oct 24, 2017

Makes cast_dfm() and tidy.dfm[Sparse]() compatible with quanteda v0.99.12 and with the upcoming quanteda v1.0 release, and fixes some tests.

In v1.0 (and in the current quanteda master >= v0.9.9000), the dfm structure has been simplified to just dfm, instead of dfmSparse and dfmDense. Methods to check and to coerce the object class exist as is.dfm() and as.dfm().

- makes cast_dfm compatible with quanteda v0.99.12 and with the upcoming v1.0 release
@codecov-io
Copy link

Codecov Report

Merging #87 into master will decrease coverage by 0.03%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage    82.5%   82.46%   -0.04%     
==========================================
  Files          10       10              
  Lines         360      365       +5     
==========================================
+ Hits          297      301       +4     
- Misses         63       64       +1
Impacted Files Coverage Δ
R/sparse_tidiers.R 100% <ø> (ø) ⬆️
R/stm_tidiers.R 92.15% <50%> (ø) ⬆️
R/sparse_casters.R 90.66% <83.33%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c87e5bd...19b6ef9. Read the comment docs.

@juliasilge juliasilge merged commit e3ee8d1 into juliasilge:master Nov 17, 2017
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants