Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes numbers being incorrectly truthy #2658

Merged
merged 2 commits into from Dec 5, 2023
Merged

Fixes numbers being incorrectly truthy #2658

merged 2 commits into from Dec 5, 2023

Conversation

OAGr
Copy link
Contributor

@OAGr OAGr commented Dec 4, 2023

Closes #2656

@OAGr OAGr requested a review from berekuk as a code owner December 4, 2023 15:40
Copy link

changeset-bot bot commented Dec 4, 2023

🦋 Changeset detected

Latest commit: df7d593

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@quri/squiggle-lang Patch
@quri/squiggle-components Patch
@quri/prettier-plugin-squiggle Patch
vscode-squiggle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Updated (UTC)
quri-hub ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 7:23pm
quri-ui ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 7:23pm
squiggle-components ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 7:23pm
squiggle-website ⬜️ Ignored (Inspect) Visit Preview Dec 5, 2023 7:23pm

Copy link
Contributor

sweep-ai bot commented Dec 4, 2023

Apply Sweep Rules to your PR?

  • Apply: All docstrings and comments should be up to date.
  • Apply: Ensure that all variables and functions have descriptive names.
  • Apply: Avoid using unnecessary separators or extra characters in code.
  • Apply: Use consistent indentation and spacing throughout the code.
  • Apply: Ensure that all code is properly formatted and follows the style guide.
  • Apply: Avoid using magic numbers or hard-coded values in the code.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (25d582f) 71.96% compared to head (3dd8044) 71.95%.
Report is 3 commits behind head on main.

❗ Current head 3dd8044 differs from pull request most recent head df7d593. Consider uploading reports for the commit df7d593 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2658      +/-   ##
==========================================
- Coverage   71.96%   71.95%   -0.01%     
==========================================
  Files         115      115              
  Lines        6231     6187      -44     
  Branches     1213     1208       -5     
==========================================
- Hits         4484     4452      -32     
+ Misses       1739     1727      -12     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berekuk berekuk merged commit 1ec1087 into main Dec 5, 2023
4 of 7 checks passed
@berekuk berekuk deleted the fix-numbers-truthy branch December 5, 2023 19:22
@github-actions github-actions bot mentioned this pull request Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

!5 == true
2 participants