-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve start/end utilization in TradingCalendar #1804
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peque
changed the title
More flexible start/end types in TradingCalendar
Improve start/end utilization in TradingCalendar
May 22, 2017
1 similar comment
This is useful to know the first and last day the calendar is representing (they do not need to match the first/last trading session in the calendar).
1 similar comment
x-ref #418 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
TradingCalendar
'sstart
andend
parameters.None
. This way it is easier to propagate undefinedstart
/end
parameters when theTradingCalendar
initialization is encapsulated in another function/method (no need to importstart_default
/end_default
to have consistent behavior).start
/end
attributes as they are useful to know the first/last day of the calendar (they do not need to match the first/last trading session in the calendar).