Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfiles for development on CPU and GPU #163

Merged
merged 7 commits into from
Aug 26, 2022

Conversation

liam-adams
Copy link
Contributor

@liam-adams liam-adams commented Jul 14, 2022

Motivation and Context

This is for issue #19

How has this been tested?

I ran make test, make package and installed causalnex from source inside both of the docker containers. All tests passed and I ran the tutorial https://causalnex.readthedocs.io/en/latest/03_tutorial/01_first_tutorial.html on the created pip package

In the gpu image I ran into the same issue described here #138

Checklist

  • [y] Read the contributing guidelines
  • [n/a] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • [y] Updated the documentation to reflect the code changes
  • [n] Added a description of this change and added my name to the list of supporting contributions in the RELEASE.md file
  • [n/a] Added tests to cover my changes
  • [y] Assigned myself to the PR

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

Copy link
Contributor

@GabrielAzevedoFerreiraQB GabrielAzevedoFerreiraQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a great addition! thanks for putting the effort into it
I'd just to clarify a few things first

devel-cpu.Dockerfile Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
devel-cpu.Dockerfile Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@oentaryorj oentaryorj self-requested a review August 26, 2022 06:58
test_requirements.txt Outdated Show resolved Hide resolved
@GabrielAzevedoFerreiraQB
Copy link
Contributor

It is good to merge! I wonder if you can just add a release note when you can, please?

@oentaryorj oentaryorj changed the title add dockerfiles for development on cpu and gpu Add Dockerfiles for development on CPU and GPU Aug 26, 2022
@oentaryorj

This comment was marked as resolved.

Copy link
Contributor

@oentaryorj oentaryorj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed scikit-learn from test_requirements and fixed linting. LGTM now

@oentaryorj oentaryorj merged commit 740997c into mckinsey:develop Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants