-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add napari-btrack-reader to this package #115
Conversation
ae47ad5
to
4653d22
Compare
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
- Coverage 80.79% 80.71% -0.09%
==========================================
Files 13 14 +1
Lines 1432 1462 +30
==========================================
+ Hits 1157 1180 +23
- Misses 275 282 +7
Continue to review full report at Codecov.
|
@quantumjot could you install the napari-hub preview app on this repository, so we can get the preview comments: https://github.com/apps/napari-hub ? |
Should be done now. |
Preview page for your plugin is ready here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks largely good!
Some very minor points that I think were there before this PR in the other repo.
Variable names could be improved a bit, I think? (but as part of a separate PR)
Co-authored-by: Alessandro Felder <alessandrofelder@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing critical but some suggestions which should improve the code quality
I have addressed the comments in the PR since I've reviewed so going to merge |
This adds the napari reader as an optional napari plugin to this package. This is entireley optional, and I've configured most of the tests to check that the
btrack
can still be run fine withoutnapari
installed. To check that the optionalnapari
bits work there is now an extratox
environment that runs the tests withnapari
installed. I've also added some docs on how users can install the dependencies needed for thenapari
plugin.I anticipate we will add
btrack-napari
in a similar way in a separate PR in the future.Fixes https://github.com/lowe-lab-ucl/napari-btrack/issues/7
Fixes lowe-lab-ucl/napari-btrack-reader#3