Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate napari btrack internally #246

Merged
merged 138 commits into from
Mar 22, 2023

Conversation

paddyroddy
Copy link
Collaborator

@paddyroddy paddyroddy commented Mar 22, 2023

We're going to archive the napari-btrack repo in favour of having it here, much like the work in #115. We've kept the git history from before.

quantumjot and others added 30 commits May 12, 2021 13:46
- dock widget no longer necessary
- functionality provided via function widget
Co-authored-by: David Stansby <dstansby@gmail.com>
Use v2 of codecov action
also populates with example cell config and segmentation
@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Mar 22, 2023

Preview page for your plugin is ready here:
https://preview.napari-hub.org/quantumjot/btrack/246
Updated: 2023-03-22T17:26:22.867037

@paddyroddy paddyroddy marked this pull request as ready for review March 22, 2023 17:06
@p-j-smith
Copy link
Collaborator

Just for some more context, this is the method we used to merge the repositories and keep the history from napari-btrack.

We've removed the napari.yaml file that was in napari-btrack and now define both the reader and widgets in the file btrack/napari.yaml.

We've moved the tests for napari-btrack to btrack/napari/test_dock_widget.py.

We've removed the napari-specific tox environment and now run the napari-based tests in all environments so we're running across all supported python versions

@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2023

Codecov Report

Patch coverage: 84.65% and project coverage change: +0.93 🎉

Comparison is base (79d3945) 82.98% compared to head (39fd8b8) 83.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #246      +/-   ##
==========================================
+ Coverage   82.98%   83.92%   +0.93%     
==========================================
  Files          19       30      +11     
  Lines        1552     1904     +352     
  Branches      260      295      +35     
==========================================
+ Hits         1288     1598     +310     
- Misses        190      219      +29     
- Partials       74       87      +13     
Impacted Files Coverage Δ
btrack/napari/widgets/io.py 42.85% <42.85%> (ø)
btrack/napari/main.py 73.33% <73.33%> (ø)
btrack/napari/widgets/create_ui.py 85.71% <85.71%> (ø)
btrack/napari/config.py 86.11% <86.11%> (ø)
btrack/napari/widgets/_motion.py 91.30% <91.30%> (ø)
btrack/napari/sync.py 91.48% <91.48%> (ø)
btrack/napari/widgets/_general.py 92.59% <92.59%> (ø)
btrack/napari/widgets/_hypothesis.py 96.22% <96.22%> (ø)
btrack/napari/__init__.py 100.00% <100.00%> (ø)
btrack/napari/constants.py 100.00% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@quantumjot quantumjot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Will be nice to see this all integrated

.napari-hub/DESCRIPTION.md Show resolved Hide resolved
@paddyroddy paddyroddy merged commit 352df87 into main Mar 22, 2023
@paddyroddy paddyroddy deleted the incorporate-napari-btrack-internally branch March 22, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate napari-btrack plugin into this repository
7 participants