Skip to content

Commit

Permalink
Python 3.8 support (#3365)
Browse files Browse the repository at this point in the history
Ensures that packages are python 3.8 compatible. 
Adds CI tests for 3.8. 
This was a work based on @seunomonije's investigations.

Fixes #3194.
Fixes #3318.
  • Loading branch information
balopat committed Sep 30, 2020
1 parent 0bb9239 commit 0d961ad
Show file tree
Hide file tree
Showing 4 changed files with 252 additions and 255 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
name: Pytest Ubuntu
strategy:
matrix:
python-version: [ '3.6', '3.7' ]
python-version: ['3.6', '3.7', '3.8']
runs-on: ubuntu-16.04
steps:
- uses: actions/checkout@v2
Expand Down Expand Up @@ -163,7 +163,7 @@ jobs:
name: Pytest Windows
strategy:
matrix:
python-version: [ '3.6', '3.7' ]
python-version: [ '3.6', '3.7', '3.8' ]
runs-on: windows-latest
steps:
- uses: actions/checkout@v2
Expand All @@ -182,7 +182,7 @@ jobs:
name: Pytest MacOS
strategy:
matrix:
python-version: [ '3.6', '3.7' ]
python-version: [ '3.6', '3.7', '3.8' ]
runs-on: macos-10.15
steps:
- uses: actions/checkout@v2
Expand Down
11 changes: 3 additions & 8 deletions dev_tools/conf/pip-list-dev-tools.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ pytest-benchmark~=3.2.0
yapf~=0.27.0

# For generating protobufs
grpcio-tools~=1.24.0

# 1.26 is the min version that has python 3.8 wheels
grpcio-tools~=1.26
mypy-protobuf==1.10

# For uploading packages to pypi.
Expand All @@ -25,10 +27,6 @@ pypandoc
myst-parser
Sphinx~=3.2.0

# have to pin otherwise RTD fails
# see https://github.com/readthedocs/readthedocs.org/issues/7492
Pygments==2.6.1

sphinx_rtd_theme
sphinx-markdown-tables

Expand All @@ -37,8 +35,5 @@ nbsphinx
ipython
ipykernel

# For google notebooks
google-colab

# For verifying rst
rstcheck~=3.3.1

0 comments on commit 0d961ad

Please sign in to comment.