-
Notifications
You must be signed in to change notification settings - Fork 990
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Previously we were blocked on upgrading asteroid due to a bug pylint-dev/astroid#650 However the bug now says this is fixed, so verifying that our tests pass. ...and it turns out they don't pass. Fixes: * `ndarray.reshape` technically takes lists of arguments like `a.reshape(1, 3, 4)`. However sometimes lint gets mad about this. Fixed this and changed other uses in this test to use same pattern for consistency. * Found a missing assertion right nearby and fixed this. Needed to fix order bug in test. * Didn't fix a lint error about the result of getattr not being callable. I don't think there is any fix besides this as there are lots of bugs about pylint messing this up. So added a disable.
- Loading branch information
Showing
4 changed files
with
21 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters