Skip to content

Commit

Permalink
Add @rmlarose as a maintainer for cirq/docs/* (#4027)
Browse files Browse the repository at this point in the history
  • Loading branch information
tanujkhattar committed Apr 15, 2021
1 parent bbaf47a commit 51b5628
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
3 changes: 2 additions & 1 deletion .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@
**/pasqal/**/*.* @HGSilveri @quantumlib/cirq-maintainers @vtomole @cduck

cirq/experiments/**/*.* @mrwojtek @quantumlib/cirq-maintainers @vtomole @cduck
cirq/docs/qcvv/**/*.* @mrwojtek @quantumlib/cirq-maintainers @vtomole @cduck
cirq/docs/**/*.* @rmlarose @quantumlib/cirq-maintainers @vtomole @cduck
cirq/docs/qcvv/**/*.* @mrwojtek @rmlarose @quantumlib/cirq-maintainers @vtomole @cduck
5 changes: 4 additions & 1 deletion dev_tools/codeowners_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@

BASE_MAINTAINERS = {CIRQ_MAINTAINERS, ('USERNAME', "@vtomole"), ('USERNAME', "@cduck")}

DOCS_MAINTAINERS = BASE_MAINTAINERS.union({('USERNAME', '@rmlarose')})

GOOGLE_TEAM = {('USERNAME', "@wcourtney")}

GOOGLE_MAINTAINERS = BASE_MAINTAINERS.union(GOOGLE_TEAM)
Expand Down Expand Up @@ -55,7 +57,8 @@ def _vendor_module_testcases(mod_name, expected_group):
("in/any/dir/any_file.py", BASE_MAINTAINERS),
("cirq/contrib/bla.py", BASE_MAINTAINERS),
("cirq/experiments/bla.py", QCVV_MAINTAINERS),
("cirq/docs/qcvv/my_fancy_notebook.ipynb", QCVV_MAINTAINERS),
("cirq/docs/qcvv/my_fancy_notebook.ipynb", QCVV_MAINTAINERS.union(DOCS_MAINTAINERS)),
("cirq/docs/any/dir/any_notebook.ipynb", DOCS_MAINTAINERS),
*_vendor_module_testcases("aqt", AQT_MAINTAINERS),
*_vendor_module_testcases("ionq", IONQ_MAINTAINERS),
*_vendor_module_testcases("google", GOOGLE_MAINTAINERS),
Expand Down

0 comments on commit 51b5628

Please sign in to comment.