Skip to content

Commit

Permalink
Bump node-fetch and puppeteer in /cirq-web/cirq_ts (#5998)
Browse files Browse the repository at this point in the history
* Bump node-fetch and puppeteer in /cirq-web/cirq_ts

Bumps [node-fetch](https://github.com/node-fetch/node-fetch) to 2.6.9 and updates ancestor dependency [puppeteer](https://github.com/puppeteer/puppeteer). These dependencies need to be updated together.


Updates `node-fetch` from 2.6.1 to 2.6.9
- [Release notes](https://github.com/node-fetch/node-fetch/releases)
- [Commits](node-fetch/node-fetch@v2.6.1...v2.6.9)

Updates `puppeteer` from 10.0.0 to 19.6.3
- [Release notes](https://github.com/puppeteer/puppeteer/releases)
- [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json)
- [Commits](puppeteer/puppeteer@v10.0.0...puppeteer-v19.6.3)

---
updated-dependencies:
- dependency-name: node-fetch
  dependency-type: indirect
- dependency-name: puppeteer
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

* Updated "expected" images for screenshot tests.

* dropme - show node.js version active on github CI

* CI - add missing setup-node for typescript tests

* CI - use actions/checkout@v3 for typescript tests

* Revert "Updated "expected" images for screenshot tests."

Check if original expected PNGs would work on GHA.

This reverts commit 5599798.

* Revert "Revert "Updated "expected" images for screenshot tests.""

No joy - back to the updated PNGs.

This reverts commit 4cf21fd.

* dropme: is there anything suspicious in puppeteer dependencies?

* Add logic that saves actual png and diff png to the directory. From a local run I can see that that the diff comes from the black/dark gray pixels.

* fix ts-lint formatting

* update the expected images with the ones generated from my macOS. The text symbols had been slightly darker and more bold (from a chrome update I suspect) causing the pixelmatcher to fail. This now passes locally on my macOS.

* Log base64 encoding of captured images by GHA's run environment so they can be reconstructed to PNGs.

* Update expected images using the pngs generated from base64 encodings of the GHA run.

* restore .ts files back to their contents in master

* Add missing import statement and remove debug statements and TODOs.

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: William Courtney <wcourtney@google.com>
Co-authored-by: Pavol Juhas <juhas@google.com>
Co-authored-by: Victory Omole <vtomole2@gmail.com>
Co-authored-by: Seneca Meeks <senecacmeeks@gmail.com>
Co-authored-by: Tanuj Khattar <tanujkhattar@google.com>
  • Loading branch information
6 people committed Mar 7, 2023
1 parent c8f7a02 commit 8b97aa5
Show file tree
Hide file tree
Showing 5 changed files with 197 additions and 45 deletions.
Binary file modified cirq-web/cirq_ts/e2e/bloch_sphere/bloch_sphere_expected.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified cirq-web/cirq_ts/e2e/bloch_sphere/bloch_sphere_expected_custom.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified cirq-web/cirq_ts/e2e/circuit/circuit_expected.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
240 changes: 196 additions & 44 deletions cirq-web/cirq_ts/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cirq-web/cirq_ts/package.json
Expand Up @@ -32,7 +32,7 @@
"nyc": "^15.1.0",
"pixelmatch": "^5.2.1",
"pngjs": "^6.0.0",
"puppeteer": "^10.0.0",
"puppeteer": "^19.6.3",
"temp": "^0.9.4",
"three": "^0.137.0",
"ts-loader": "^9.1.2",
Expand Down

0 comments on commit 8b97aa5

Please sign in to comment.