Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Protos test unexplained failure #6214

Closed
NoureldinYosri opened this issue Jul 21, 2023 · 1 comment
Closed

Build Protos test unexplained failure #6214

NoureldinYosri opened this issue Jul 21, 2023 · 1 comment
Labels
kind/bug-report Something doesn't seem to work.

Comments

@NoureldinYosri
Copy link
Collaborator

Description of the issue
Build Protos test fails with ERROR: Uncommitted generated files found! Please generate and commit these files using dev_tools/build-protos.sh:, eventhough the dev_tools/build-protos.sh was run and the files commited (e.g. https://github.com/quantumlib/Cirq/actions/runs/5621595069/job/15232679900?pr=6212).

The script dev_tools/build-protos.sh also pulls files not affected by the change. This might be related to the recent proto version update.

How to reproduce the issue

Any valid change to the proto files will probably trigger it. for example #6212

@NoureldinYosri NoureldinYosri added the kind/bug-report Something doesn't seem to work. label Jul 21, 2023
@NoureldinYosri
Copy link
Collaborator Author

NoureldinYosri commented Jul 21, 2023

this is a python & dependency version problem. The test runs with python=3.9 and grpcio-tools~=1.56.0. My virtual env had python=3.10 and grpcio-tools=1.56.2.

I fixed the issue by generating the protos in an environment with the correct verions

conda create -n protos-env python=3.9 
conda activate protos-env
pip install -r dev_tools/requirements/deps/protos.txt
dev_tools/build-protos.sh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-report Something doesn't seem to work.
Projects
None yet
Development

No branches or pull requests

1 participant