New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create cirq_google.api.v2.InternalGate proto #6212
Conversation
@dstrain115 any idea what is happening with the protos test, I built the protos with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, though it pulled in a bunch of irrelevant changes. Is this due to the upgrade in protobuf libraries and python version?
@dstrain115 The test assumes python=3.9. my virtual environment had python=3.10. I fixed the issue and documented the solution in #6214 (comment) Now this PR is block on the notebooks test which is failing on master #6213 |
This PR:
cirq_google.api.v2.InternalGate
intoprogram.proto
and regenerates the autogeneratedpy
and mypy files.ArgValue
to also accept lists of strings, ints, and floats.circuit_serializer.py
andarg_func_langs.py
to understand the new types/options for serialization and deserialization.__repr__
method ofInternalGate
originally proposed in #6210