Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create cirq_google.api.v2.InternalGate proto #6212

Merged
merged 9 commits into from Jul 25, 2023
Merged

Conversation

NoureldinYosri
Copy link
Collaborator

@NoureldinYosri NoureldinYosri commented Jul 20, 2023

This PR:

  • Introduces cirq_google.api.v2.InternalGate into program.proto and regenerates the autogenerated py and mypy files.
  • Updates ArgValue to also accept lists of strings, ints, and floats.
  • Updates circuit_serializer.py and arg_func_langs.py to understand the new types/options for serialization and deserialization.
  • Fixes the __repr__ method of InternalGate

originally proposed in #6210

@CirqBot CirqBot added the size: L 250< lines changed <1000 label Jul 20, 2023
@NoureldinYosri
Copy link
Collaborator Author

@dstrain115 any idea what is happening with the protos test, I built the protos with dev_tools/build-protos.sh as the tests says.

Copy link
Collaborator

@dstrain115 dstrain115 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, though it pulled in a bunch of irrelevant changes. Is this due to the upgrade in protobuf libraries and python version?

cirq-google/cirq_google/serialization/arg_func_langs.py Outdated Show resolved Hide resolved
@NoureldinYosri
Copy link
Collaborator Author

@dstrain115 The test assumes python=3.9. my virtual environment had python=3.10. I fixed the issue and documented the solution in #6214 (comment)

Now this PR is block on the notebooks test which is failing on master #6213

@NoureldinYosri NoureldinYosri enabled auto-merge (squash) July 25, 2023 19:57
@NoureldinYosri NoureldinYosri merged commit 43f6a7f into master Jul 25, 2023
33 checks passed
@NoureldinYosri NoureldinYosri deleted the internal_gate2 branch July 26, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: L 250< lines changed <1000
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants