Add `assert_specifies_has_unitary_if_unitary` to consistency tests #1759

Strilanc · 2019-06-27T20:15:47Z

No description provided.

# Conflicts: # cirq/testing/consistent_protocols.py

cduck · 2019-07-17T17:07:13Z

Is this intended to change the protocol to require _has_unitary_ or to just require that we always use _has_unitary_ within Cirq?

Strilanc · 2019-07-17T19:54:14Z

It's intended to ensure we always use it within cirq

cirq/ops/raw_types.py

cirq/testing/__init__.py

cirq/testing/consistent_protocols.py

cduck · 2019-07-17T21:24:07Z

cirq/testing/consistent_protocols_test.py

@@ -33,6 +33,9 @@ def __init__(self,
        self.phase_exponent = cirq.canonicalize_half_turns(phase_exponent)
        self.exponent = exponent

+    def _has_unitary_(self):
+        return not cirq.is_parameterized(self)
+
    def _unitary_(self) -> Union[np.ndarray, NotImplementedType]:
        if cirq.is_parameterized(self):


Nit: Inconsistent with other places.

cduck · 2019-07-17T21:24:11Z

cirq/testing/consistent_protocols_test.py

@@ -33,6 +33,9 @@ def __init__(self,
        self.phase_exponent = cirq.canonicalize_half_turns(phase_exponent)
        self.exponent = exponent

+    def _has_unitary_(self):
+        return not cirq.is_parameterized(self)


Nit: Inconsistent with other places.

cirq/testing/consistent_specified_has_unitary.py

cduck · 2019-07-17T21:31:45Z

cirq/ops/fsim_gate.py

@@ -66,6 +66,9 @@ def _is_parameterized_(self):
        return cirq.is_parameterized(self.theta) or cirq.is_parameterized(
            self.phi)

+    def _has_unitary_(self):
+        return not self._is_parameterized_()
+
    def _unitary_(self) -> Optional[np.ndarray]:
        if cirq.is_parameterized(self):


Nit: Inconsistent with other places.

In what way?

Often self._is_parameterized_() is used instead.

cduck · 2019-07-22T17:35:13Z

Ping @Strilanc.

# Conflicts: # cirq/ops/common_gates.py # cirq/ops/matrix_gates.py # cirq/ops/raw_types.py # cirq/testing/consistent_protocols.py

# Conflicts: # cirq/ops/identity.py

Strilanc · 2019-11-19T00:53:06Z

Ping @cduck

cduck

LGTM. Just one qudit compatibility issue.

cduck · 2019-11-19T16:29:02Z

cirq/ops/fsim_gate.py

@@ -66,6 +66,9 @@ def _is_parameterized_(self):
        return cirq.is_parameterized(self.theta) or cirq.is_parameterized(
            self.phi)

+    def _has_unitary_(self):
+        return not self._is_parameterized_()
+
    def _unitary_(self) -> Optional[np.ndarray]:
        if cirq.is_parameterized(self):


Often self._is_parameterized_() is used instead.

cduck · 2019-11-19T16:31:10Z

cirq/ops/raw_types.py

@@ -449,6 +449,14 @@ def _decompose_(self, qubits):
        return protocols.inverse(
            protocols.decompose_once_with_qubits(self._original, qubits))

+    def _has_unitary_(self):
+        from cirq import protocols, devices
+        qubits = devices.LineQubit.range(self._num_qubits_())


This should be LineQid.for_gate(self).

# Conflicts: # cirq/ops/pauli_string_phasor.py

Strilanc · 2019-11-20T09:43:31Z

Often self.is_parameterized() is used instead.

Done

CirqBot · 2019-11-20T10:01:29Z

Automerge cancelled: A status check is failing.

cduck · 2019-11-20T14:14:49Z

Did you intentionally remove IdentityOperation.gate or is that a merge issue?

Strilanc · 2019-11-20T21:01:32Z

It was a merge issue

CirqBot · 2019-11-27T20:17:31Z

Automerge cancelled: There are merge conflicts.

cduck · 2019-11-27T20:18:08Z

Ping @Strilanc.

# Conflicts: # docs/api.rst

…sity_sanityG

CirqBot · 2019-12-17T08:08:35Z

Automerge cancelled: A status check is failing.

# Conflicts: # cirq/ops/identity.py # cirq/ops/raw_types_test.py # cirq/testing/consistent_protocols.py

CirqBot · 2020-04-28T22:18:14Z

Automerge cancelled: A status check is failing.

Add assert_specifies_has_unitary_if_unitary to consistency tests

98daa76

Strilanc requested a review from dabacon June 27, 2019 20:15

googlebot added the cla: yes Makes googlebot stop complaining. label Jun 27, 2019

Strilanc added 3 commits July 16, 2019 19:05

Merge branch 'master' of github.com:quantumlib/Cirq into density_sanityG

d152a37

# Conflicts: # cirq/testing/consistent_protocols.py

fix failures

c243871

format

88b6a69

Strilanc requested a review from cduck July 17, 2019 02:19

cover

8b0d64f

cduck requested changes Jul 17, 2019

View reviewed changes

Strilanc added 3 commits November 7, 2019 18:29

Merge branch 'master' of github.com:quantumlib/Cirq into density_sanityG

0d4c1ac

# Conflicts: # cirq/ops/common_gates.py # cirq/ops/matrix_gates.py # cirq/ops/raw_types.py # cirq/testing/consistent_protocols.py

comments

1771d54

Merge branch 'master' of github.com:quantumlib/Cirq into density_sanityG

e2954d0

# Conflicts: # cirq/ops/identity.py

Strilanc added the Ready for Re-Review For when reviewers take their time. label Nov 19, 2019

x

44d9b68

cduck approved these changes Nov 19, 2019

View reviewed changes

Merge branch 'master' of github.com:quantumlib/Cirq into density_sanityG

26b7396

# Conflicts: # cirq/ops/pauli_string_phasor.py

Strilanc added automerge Tells CirqBot to sync and merge this PR. (If it's running.) and removed Ready for Re-Review For when reviewers take their time. labels Nov 20, 2019

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 20, 2019

cover

23fb49e

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Nov 20, 2019

CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Nov 21, 2019

cduck added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 27, 2019

CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Nov 27, 2019

Strilanc added 2 commits December 16, 2019 23:48

Merge branch 'master' of github.com:quantumlib/Cirq into density_sanityG

d72da36

# Conflicts: # docs/api.rst

Merge branch 'density_sanityG' of github.com:quantumlib/Cirq into den…

0a9e9aa

…sity_sanityG

Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Dec 17, 2019

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Dec 17, 2019

Merge branch 'master' into density_sanityG

3209509

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Dec 17, 2019

Strilanc added 5 commits April 28, 2020 14:54

Merge branch 'master' of github.com:quantumlib/Cirq into density_sanityG

92e0cc8

# Conflicts: # cirq/ops/identity.py # cirq/ops/raw_types_test.py # cirq/testing/consistent_protocols.py

merge

5074393

typecheck

80051c6

Merge branch 'master' of github.com:quantumlib/Cirq into density_sanityG

5a67844

type fix

7e1a222

Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 28, 2020

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 28, 2020

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Apr 28, 2020

format

4994a71

Strilanc added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 28, 2020

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 28, 2020

CirqBot merged commit a3af71f into master Apr 28, 2020

CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Apr 28, 2020

CirqBot deleted the density_sanityG branch April 28, 2020 22:27

CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Apr 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add `assert_specifies_has_unitary_if_unitary` to consistency tests #1759

Add `assert_specifies_has_unitary_if_unitary` to consistency tests #1759

Strilanc commented Jun 27, 2019 •

edited

cduck commented Jul 17, 2019

Strilanc commented Jul 17, 2019

cduck Jul 17, 2019

cduck Jul 17, 2019

Strilanc Nov 8, 2019

cduck Jul 17, 2019

Strilanc Nov 8, 2019

cduck Nov 19, 2019

cduck commented Jul 22, 2019

Strilanc commented Nov 19, 2019

cduck left a comment

cduck Nov 19, 2019

cduck Nov 19, 2019

Strilanc Nov 20, 2019

Strilanc commented Nov 20, 2019

CirqBot commented Nov 20, 2019

cduck commented Nov 20, 2019

Strilanc commented Nov 20, 2019

CirqBot commented Nov 27, 2019

cduck commented Nov 27, 2019

CirqBot commented Dec 17, 2019

CirqBot commented Apr 28, 2020

Add assert_specifies_has_unitary_if_unitary to consistency tests #1759

Add assert_specifies_has_unitary_if_unitary to consistency tests #1759

Conversation

Strilanc commented Jun 27, 2019 • edited

cduck commented Jul 17, 2019

Strilanc commented Jul 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cduck commented Jul 22, 2019

Strilanc commented Nov 19, 2019

cduck left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Strilanc commented Nov 20, 2019

CirqBot commented Nov 20, 2019

cduck commented Nov 20, 2019

Strilanc commented Nov 20, 2019

CirqBot commented Nov 27, 2019

cduck commented Nov 27, 2019

CirqBot commented Dec 17, 2019

CirqBot commented Apr 28, 2020

Add `assert_specifies_has_unitary_if_unitary` to consistency tests #1759

Add `assert_specifies_has_unitary_if_unitary` to consistency tests #1759

Strilanc commented Jun 27, 2019 •

edited