Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore python3-tk as an apt requirement #1876

Merged
merged 1 commit into from Jul 26, 2019
Merged

Restore python3-tk as an apt requirement #1876

merged 1 commit into from Jul 26, 2019

Conversation

Strilanc
Copy link
Contributor

  • I needed to install this to get matplotlib working

@Strilanc
Restore python3-tk as an apt requirement
8bd9cd1 
- I needed to install this to get matplotlib working
@Strilanc Strilanc requested a review from cduck July 25, 2019 23:26
@googlebot googlebot added the cla: yes Makes googlebot stop complaining. label Jul 25, 2019
@dabacon
Copy link
Collaborator

dabacon commented Jul 25, 2019

Any idea why this changed from your last update? #1728

@dabacon dabacon self-requested a review July 25, 2019 23:50
@dabacon dabacon added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 26, 2019
@CirqBot CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 26, 2019
@CirqBot CirqBot merged commit 83adc07 into master Jul 26, 2019
@CirqBot CirqBot removed the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Jul 26, 2019
@CirqBot CirqBot deleted the asyncifyD branch July 26, 2019 00:24
@CirqBot CirqBot removed the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Jul 26, 2019
@Strilanc
Copy link
Contributor Author

I'm not sure. Perhaps uninstalling python3-tk didn't really remove it, or perhaps I had installed some other dependency that was filling in the blank. In the future we should only remove this after testing that it works on a fresh virtual machine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabacon dabacon dabacon approved these changes

@cduck cduck Awaiting requested review from cduck

Assignees
No one assigned
Labels
cla: yes Makes googlebot stop complaining.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Strilanc @dabacon @googlebot @CirqBot