Added BB84_example #2395

abhishekchak52 · 2019-10-23T10:28:47Z

Fix for #2367

googlebot · 2019-10-23T10:28:51Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

abhishekchak52 · 2019-10-23T10:31:10Z

@googlebot I signed it!

googlebot · 2019-10-23T10:31:13Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

vtomole

Thanks for doing this. This program ran for over 10 minutes on my machine without terminating (I had to do it manually). I'll add more feedback once we get this running on Travis.

vtomole · 2019-10-23T11:07:43Z

examples/BB84_cirq.py

@@ -0,0 +1,148 @@
+# Example program to demonstrate BB84 QKD Protocol


Rename this file to bb84.py

vtomole · 2019-10-23T11:14:23Z

examples/BB84_cirq.py

+    print_results(alice_basis, bob_basis, alice_state, key_bitstr)
+
+
+def build_bb84_circ(num_qubits, alice_basis, bob_basis, alice_state):


Rename to make_bb84_circuit

vtomole · 2019-10-23T15:45:59Z

examples/BB84_cirq.py

+import cirq
+
+
+def main():


Call this code in https://github.com/quantumlib/Cirq/blob/master/examples/examples_test.py to cover it on Travis.

vtomole · 2019-10-23T15:57:37Z

examples/BB84_cirq.py

+    print(
+        f'Alice\'s sent bits:\t{np.array2string(alice_state, separator="")[1:-1]}'
+    )
+    print(f'Both bases Match::\t{basis_match}')


Call an assert on expected_key_bits == actual_key_bits.

vtomole · 2019-10-23T16:14:55Z

examples/BB84_cirq.py

+
+def main():
+
+    num_qubits = 24


This is a lot of qubits for NISQ. Since we are going to be running this on Travis, let's use less resources.

I've reduced it to 16 :)

vtomole · 2019-10-23T16:24:31Z

examples/BB84_cirq.py

+    print(
+        f'Alice\'s sent bits:\t{np.array2string(alice_state, separator="")[1:-1]}'
+    )
+    print(f'Both bases Match::\t{basis_match}')


.format will make this an easier read. print('Both bases Match: {}'.format(basis_match))

vtomole · 2019-10-23T16:24:54Z

examples/BB84_cirq.py

+    print(
+        f'Bob\'s Encoding basis:\t{"".join(np.where(bob_basis==0, "C", "H"))}')
+    print(
+        f'Alice\'s sent bits:\t{np.array2string(alice_state, separator="")[1:-1]}'


Use .format to make this cleaner. See below suggestion.

vtomole · 2019-10-23T16:24:59Z

examples/BB84_cirq.py

+        f'Alice\'s Encoding basis:\t{"".join(np.where(alice_basis==0, "C","H"))}'
+    )
+    print(
+        f'Bob\'s Encoding basis:\t{"".join(np.where(bob_basis==0, "C", "H"))}')


Use .format to make this cleaner. See below suggestion.

vtomole · 2019-10-23T16:25:07Z

examples/BB84_cirq.py

+        basis_match += 'X' if alice_basis[i] == bob_basis[i] else '_'
+        key_expected += str(char) if alice_basis[i] == bob_basis[i] else '_'
+
+    print(


Use .format to make this cleaner. See below suggestion.

Based on error logs from formatting test on Travis

abhishekchak52 · 2019-10-23T18:29:21Z

I've added the suggested changes. Thanks for the guidance. What else do I need to do?

vtomole

This takes 6 seconds to run on my machine. If we can half the runtime, that would be good.

A huge improvement we can make is on this program being filled with conversion of types. It makes it harder to read as an example. We could start with arrays of ints or strings as the states and bases and get rid of the brackets at the very end of the program. Try to reduce the number of calls to things like str, np.array2string, [1:-1], np.array. Let's try to defer the conversions to the very end when we need the data to be in a human readable format, not between the programs.

examples/bb84.py

abhishekchak52 · 2019-10-24T18:43:29Z

@vtomole Could you point me to some resources which talk about how to get formatted output from the simulator? So far, I've been able to get output in Boolean form only.

vtomole · 2019-10-24T18:48:11Z

@deadbeatfour What's an example of what you need?

vtomole · 2019-11-11T21:36:14Z

Ping @deadbeatfour

abhishekchak52 · 2019-11-12T14:04:27Z

Hey, sorry! I'm busy with some exams right now. I'll get back to you ASAP!

vtomole · 2019-11-12T15:01:07Z

@deadbeatfour No rush. Good luck on your exams!

vtomole · 2020-02-18T23:10:47Z

Hey @deadbeatfour , I'd like to get this in. Please respond to my comments.

abhishekchak52 · 2020-02-20T06:31:07Z

Hey, really sorry. I'll get on it right away. I'll make the changes you requested.

- Removed all numpy calls - Replaced all numpy.random functions with python standard library random function - Using list comprehensions instead of np.where() - Assert equality of keys before printing result - Use doctring at the beginnnig

vtomole

Using 16 qubits to demonstrate this is a lot. It takes about 3 seconds to run on my machine. Let's reduce this.

examples/bb84.py

vtomole

Still need to address change > to ⟩" comments.

examples/bb84.py

abhishekchak52 · 2020-02-25T07:19:01Z

Should I add Eve to the same file?
In the case of an eavesdropper being present, the assert at the end will fail sometimes. So what would the final output of the program be?

Should I reduce the qubit number to 8?

Changed angle brackets, corrected typos

vtomole · 2020-02-25T13:45:18Z

Should I add Eve to the same file?

Yes. Let's add a situation with Eve. We should have another assert for when the channel is evesdropped. I'm thinking something like this output

Simulating non-eavesdropped protocol
Alice's basis:  HHHCHHCHCCHHHHHH
Bob's basis:    HCCHCCHCHHHHHHCH
Alice's bits:   1100101110101101
Bases match::   X_________XXXX_X
Expected key:   110111
Actual key:     110111


Simulating eavesdropped protocol
.....
Expected key:   100000
Actual key:     110111

Should I reduce the qubit number to 8?

Sure.

abhishekchak52 · 2020-02-28T08:36:58Z

We should have another assert for when the channel is eavesdropped.

What should we assert here? There's a probability that the keys do not match, but for a small number of qubits, it's reasonably likely for eavesdropping to go undetected as well.

vtomole · 2020-02-28T14:20:54Z

@deadbeatfour What if we seed the random generator so we get the same data every time? Just for the protocol that involves Eve.

vtomole · 2020-03-13T16:14:17Z

@deadbeatfour I now think Eve is best left for a subsequent pull request. Let's just get this merged.

abhishekchak52 · 2020-03-13T19:49:13Z

Hey, I've put in the bit with eavesdropping.

vtomole

Thank you so much! One last thing. The papers you cited require that i have a subscription to read them. Let's replace them with https://en.wikipedia.org/wiki/BB84 and https://en.wikipedia.org/wiki/No-cloning_theorem.

vtomole

Attempting to re-merge.

abhishekchak52 · 2020-03-13T20:12:46Z

Thanks :)

vtomole · 2020-03-13T20:14:33Z

No, thank you. :D

Added BB84_example

4c51a2d

googlebot added the cla: no label Oct 23, 2019

googlebot added cla: yes Makes googlebot stop complaining. and removed cla: no labels Oct 23, 2019

Updated formatting

bf40481

vtomole requested changes Oct 23, 2019

View reviewed changes

abhishekchak52 added 5 commits October 23, 2019 23:11

Changed filename and reduced number of qubits

a40e8c1

Added test coverage

79e8a71

Better output readability and assert equality of keys

6deb062

Better formatting in examples_test.py

862458f

Updated examples_test.py formatting

375ed8f

Based on error logs from formatting test on Travis

Merge branch 'master' into master

71a62b2

abhishekchak52 requested a review from vtomole October 24, 2019 12:46

vtomole requested changes Oct 24, 2019

View reviewed changes

examples/bb84.py Outdated Show resolved Hide resolved

examples/bb84.py Outdated Show resolved Hide resolved

examples/bb84.py Outdated Show resolved Hide resolved

Merge branch 'master' into master

f5b24bb

Merge branch 'master' into master

a913956

abhishekchak52 added 3 commits February 23, 2020 11:59

Optimized bb84

5b4c793

- Removed all numpy calls - Replaced all numpy.random functions with python standard library random function - Using list comprehensions instead of np.where() - Assert equality of keys before printing result - Use doctring at the beginnnig

yapf google formatting

927c5b9

Changed import order

d16e741

vtomole requested changes Feb 24, 2020

View reviewed changes

examples/bb84.py Outdated Show resolved Hide resolved

examples/bb84.py Outdated Show resolved Hide resolved

examples/bb84.py Outdated Show resolved Hide resolved

examples/bb84.py Outdated Show resolved Hide resolved

Corrected docstring description

680870d

abhishekchak52 requested a review from vtomole February 24, 2020 18:30

vtomole requested changes Feb 24, 2020

View reviewed changes

examples/bb84.py Outdated Show resolved Hide resolved

Corrected docstring

69a11dc

Changed angle brackets, corrected typos

abhishekchak52 added 5 commits March 13, 2020 23:19

Reduced number of qubits

ae2ab82

Added eavesdropping example

fa98d62

Updated docstring

763076f

Corrected import order

00ba939

Random seed only eve protocol

671c177

abhishekchak52 requested a review from vtomole March 13, 2020 19:49

vtomole approved these changes Mar 13, 2020

View reviewed changes

abhishekchak52 and others added 2 commits March 14, 2020 01:39

Changed to Wikipedia links

10a08be

Merge branch 'master' into master

cfe0322

vtomole approved these changes Mar 13, 2020

View reviewed changes

vtomole added the automerge Tells CirqBot to sync and merge this PR. (If it's running.) label Mar 13, 2020

CirqBot added the front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. label Mar 13, 2020

CirqBot merged commit 626e16e into quantumlib:master Mar 13, 2020

CirqBot removed automerge Tells CirqBot to sync and merge this PR. (If it's running.) front_of_queue_automerge CirqBot uses this label to indicate (and remember) what's being merged next. labels Mar 13, 2020

		@@ -0,0 +1,148 @@
		# Example program to demonstrate BB84 QKD Protocol

		print_results(alice_basis, bob_basis, alice_state, key_bitstr)


		def build_bb84_circ(num_qubits, alice_basis, bob_basis, alice_state):

Added BB84_example #2395

Added BB84_example #2395

Conversation

abhishekchak52 commented Oct 23, 2019

googlebot commented Oct 23, 2019

What to do if you already signed the CLA

Individual signers

Corporate signers

abhishekchak52 commented Oct 23, 2019

googlebot commented Oct 23, 2019

vtomole left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vtomole Oct 23, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhishekchak52 commented Oct 23, 2019

vtomole left a comment

Choose a reason for hiding this comment

abhishekchak52 commented Oct 24, 2019

vtomole commented Oct 24, 2019

vtomole commented Nov 11, 2019

abhishekchak52 commented Nov 12, 2019

vtomole commented Nov 12, 2019

vtomole commented Feb 18, 2020

abhishekchak52 commented Feb 20, 2020

vtomole left a comment • edited

Choose a reason for hiding this comment

vtomole left a comment

Choose a reason for hiding this comment

abhishekchak52 commented Feb 25, 2020

vtomole commented Feb 25, 2020

abhishekchak52 commented Feb 28, 2020

vtomole commented Feb 28, 2020

vtomole commented Mar 13, 2020

abhishekchak52 commented Mar 13, 2020

vtomole left a comment • edited

Choose a reason for hiding this comment

vtomole left a comment

Choose a reason for hiding this comment

abhishekchak52 commented Mar 13, 2020

vtomole commented Mar 13, 2020

vtomole Oct 23, 2019 •

edited

vtomole left a comment •

edited

vtomole left a comment •

edited