Add WaitGate proto serialization #2437
Conversation
cirq/google/common_serializers.py
Outdated
| @@ -280,3 +280,24 @@ def _near_mod_2(e, t, atol=1e-8): | |||
| gate_constructor=lambda: ops.FSimGate(theta=-np.pi / 4, phi=0), | |||
| args=[]), | |||
| ] | |||
| """Measurement serializer.""" | |||
There was a problem hiding this comment.
Fix comments. Also, Matthew suggested in a different PR that we use comments instead of string literals to improve formatting (I'll fix the other ones)
cirq/google/gate_sets.py
Outdated
| SINGLE_QUBIT_HALF_PI_SERIALIZERS, SINGLE_QUBIT_HALF_PI_DESERIALIZERS, | ||
| MEASUREMENT_SERIALIZER, MEASUREMENT_DESERIALIZER, SYC_SERIALIZER, | ||
| SYC_DESERIALIZER, SQRT_ISWAP_SERIALIZERS, SQRT_ISWAP_DESERIALIZERS, | ||
| WAIT_GATE_SERIALIZER, WAIT_GATE_DESERIALIZER) |
There was a problem hiding this comment.
Add trailing comma so that the formatting remains the same?
cirq/google/gate_sets.py
Outdated
| @@ -36,12 +30,14 @@ | |||
| *SINGLE_QUBIT_SERIALIZERS, | |||
| *SINGLE_QUBIT_HALF_PI_SERIALIZERS, | |||
| MEASUREMENT_SERIALIZER, | |||
| WAIT_GATE_SERIALIZER, | |||
There was a problem hiding this comment.
We should not add this to the gate set until it is supported at the server
There was a problem hiding this comment.
i.e. add the serializer first but not to the gate set.
There was a problem hiding this comment.
Isn't the server using this same gate set object, though? How can I add it to one before the other if they're the same thing?
I suppose I could add it to the deserializers first.
Strilanc
changed the title
|
Refactored this to only define the serializer and deserializer, without adding it to the gate sets. |
| op_serializer.SerializingArg( | ||
| serialized_name='nanos', | ||
| serialized_type=float, | ||
| gate_getter=lambda e: e.duration.total_nanos()), |
There was a problem hiding this comment.
I wonder if we should put a limit here, like don't allow waits of more than 10 milliseconds (or should this be on the pyle side)?
There was a problem hiding this comment.
Yeah, that'd be a good idea.
There was a problem hiding this comment.
At least maybe yell if this is negative for now.
Strilanc
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
No description provided.